Repository navigation
Support ArraysOfArrays v1 - #23
Merged
AntonOresten merged 1 commit intoAug 27, 2026
Merged
Conversation
Widen the ArraysOfArrays compat entry to "0.6.5, 1" and replace the two
call sites that ArraysOfArrays v1 deprecates by their cross-version
equivalents: the nested-array constructor by `convert(ArrayOfSimilarArrays,
...)` and `nestedview(A, M)` by the `ArrayOfSimilarArrays{T,M}(A)`
constructor. Both forms exist unchanged in ArraysOfArrays 0.6.
Created by generative AI.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 49.65% 49.65%
=======================================
Files 8 8
Lines 431 431
=======================================
Hits 214 214
Misses 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I maintain ArraysOfArrays.jl, and since v1 is now out I went through the downstream packages that depend on it — this PR makes ForwardBackward.jl work with it.
What changed in ArraysOfArrays v1
The element type of an
ArrayOfSimilarArraysis now a view rather than a copy, and as part of that cleanup the nested-array constructors (ArrayOfSimilarArrays(A::AbstractArray{<:AbstractArray})) andnestedviewwere deprecated in favour ofconvert/stackedandsliced.The changes here
Two call sites in
src/manifolds.jluse the deprecated APIs:ArrayOfSimilarArrays(state)convert(ArrayOfSimilarArrays, state)nestedview(nt.data, length(innersize(state.state)))ArrayOfSimilarArrays{eltype(nt.data), length(innersize(state.state))}(nt.data)Both replacements are cross-version:
convert(::Type{ArrayOfSimilarArrays}, ::AbstractArray{<:AbstractArray})and theArrayOfSimilarArrays{T,M}(flat_data)constructor exist, undeprecated, in ArraysOfArrays 0.6.5, 0.6.6 and 1.0.x alike. So the compat entry widens to"0.6.5, 1"rather than dropping 0.6 — nobody currently on 0.6 is forced to move.Everything else already carried over unchanged:
flatview,innersize, and the<:ArrayOfSimilarArraysdispatch inFunctors.functorall behave the same in v1.Nothing else is touched — no version bump, no
juliacompat change, no test changes.Verification
Against ArraysOfArrays 1.0.2, 0.6.6 and 0.6.5 in turn, each in a fresh
julia --depwarn=yessession:Pkg.test()— 93/93 passing on all three.Manifoldsdependency, so it never touches these two lines. I therefore ran targeted checks withManifoldsloaded (soManifoldsExtis active):ManifoldStateonSphere(2)from a nested array of points, onProbabilitySimplex(2)via the integer constructor in the extension, plusFunctors.functor/fmapround trips through thereconstructclosure (which is what exercises the second line),tensor,similar,copy,interpolateandendpoint_conditioned_sample(deterministic and stochastic).Two small notes
CompatHelperworkflow is currently in statedisabled_inactivity(GitHub auto-disables scheduled workflows on repos after a period of inactivity), so no automated compat bump would have reached you here — worth re-enabling if you want those PRs back.Manifolds-based testset would give CI coverage of thisManifoldState/Functorspath, which is the only part of the package that touches these APIs.A small request
If this looks good, a patch release (0.1.6) would let the registry admit ArraysOfArrays 1 for ForwardBackward — Flowfusion.jl then picks it up automatically through its own bounds. Happy to adjust anything here, and thanks for the package!
🤖 Generated with Claude Code