Repository navigation
MIR-1686 Use REST API v2 instead of MCRFileNodeServlet in export formats - #1528
Merged
yagee-de merged 3 commits intoOct 27, 2026
Conversation
16 of 21 tasks
Link to files and derivates through the REST API v2 (contents and archive/zip)
instead of MCRFileNodeServlet and MCRZipServlet in the export formats oai_dc,
epicur, xMetaDissPlus and the Dissemin status. The link to
MCRZipServlet/{objectId} for objects with more than one derivate is unchanged.
…ats link archives via contents.zip
sebhofmann
force-pushed
the
issues/MIR-1686-Use_REST_API_v2_instead_of_MCRFileNodeServlet_in_export_formats
branch
from
October 26, 2026 12:08
6c6c901 to
883e7b3
Compare
golsch
requested changes
Oct 26, 2026
Comment on lines
52
to
58
| <xsl:value-of select="concat($WebApplicationBaseURL, | ||
| 'servlets/MCRFileNodeServlet/', | ||
| 'api/v2/objects/', | ||
| /mycoreobject/@ID, | ||
| '/derivates/', | ||
| $derivate/@xlink:href, | ||
| '/', | ||
| '/contents/', | ||
| $derivate/maindoc/text())"/> |
Member
There was a problem hiding this comment.
- If there are multiple derivates with a
maindoc,concatcauses cardinality issues - The
maindocmay need to be encoded
…ats fix cardinality and encode maindoc in dissemin status
golsch
approved these changes
Oct 27, 2026
yagee-de
deleted the
issues/MIR-1686-Use_REST_API_v2_instead_of_MCRFileNodeServlet_in_export_formats
branch
October 27, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to jira.
Replaces links to
MCRFileNodeServletandMCRZipServletin the MIR export formats by links to the REST API v2:mods2oai_dc.xsl(dc:identifier)mods2epicur.xslmods2xMetaDissPlus.xsl(ddb:transfer)mycoreobject2dissemin-status.xsl(pdf_url)A single file is linked as
api/v2/objects/{mcrid}/derivates/{derid}/contents/{path}, all files of one derivate asapi/v2/objects/{mcrid}/derivates/{derid}/contents.zip. The link toMCRZipServlet/{objectId}(object with more than one derivate) is unchanged until it is clarified how this case is handled in the REST API.This is the MIR part of MCR-3858 and MCR-3860 (MyCoRe PR: MyCoRe-Org/mycore#3162 provides the archive support, the MyCoRe export formats are changed in MCR-3860). The archive links need the archive support from MCR-3858.
How to test
Tested locally against a deployed MIR with a published object with one file and with several files (including a sub directory) via the OAI interface (
epicur,xMetaDissPlus,mods): a single file is linked ascontents/{path}, several files ascontents.zip, and the links deliver the file or the archive.mycoreobject2dissemin-status.xslwas not tested.oai_dcdelivers an empty result onmain, independent of this change (see MIR-1687). Sooai_dccould not be checked with this change either.