Repository navigation
Conversation
- MCRRoleManager: keep system roles in an immutable snapshot that is replaced as a whole on reload instead of clearing and refilling shared collections; listSystemRoles() returns an unmodifiable, up-to-date list - MCRCategoryDAOImpl: use AtomicLong and ConcurrentHashMap for last modified timestamps; timestamps are now strictly increasing, so changes within the same millisecond are detected by caches - MCRLayoutUtilities: cache navigation items per parsed document in a ConcurrentHashMap instead of a global HashMap that was cleared by the refresh thread and could keep items of an outdated navigation.xml; webpage IDs not found in the navigation are no longer stored (they were never served from the cache anyway, but let the map grow unbounded) - add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to jira.
Pull Request Checklist (Author)
Please go through the following checklist before assigning the PR for review:
Ticket & Documentation
fixed-versionis correctly set in the ticket and matches the PR's target branch (main).Feature & Improvement Specific Checks
Bugfix-Specific Checks
Testing
MCR Conventions & Metadata
mycore.properties.mycore.properties.Multi-Repo Considerations
MIRrequired?