Repository navigation
MCR-3890 follow MCR.XMLParser.ValidateSchema when loading MCRBase from URI - #3193
Merged
kkrebs merged 2 commits intoOct 28, 2026
Merged
Conversation
rsteph-de
self-requested a review
October 27, 2026 14:10
rsteph-de
approved these changes
Oct 27, 2026
| protected final void setFromURI(URI uri) throws JDOMException, IOException { | ||
| setFromXML(new MCRURLContent(uri.toURL()).asByteArray(), false); | ||
| setFromXML(new MCRURLContent(uri.toURL()).asByteArray(), | ||
| MCRConfiguration2.getOrThrow("MCR.XMLParser.ValidateSchema", Boolean::parseBoolean)); |
Member
There was a problem hiding this comment.
Did you consider reusing
MCRXMLParserFactory.VALIDATE_BY_DEFAULT
here?
kkrebs
deleted the
issues/MCR-3890-Load_from_URI_ignores_ValidateSchema
branch
October 28, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to jira
MCRBase.setFromURIhas used a hard coded non validating parser since the clean up in MCR-2862 (27bc8fcc2c). It followsMCR.XMLParser.ValidateSchemaagain, as it did before. This affectsnew MCRObject(URI)andnew MCRDerivate(URI), and with them the CLI load/update commands and the REST API v1 object upload.Pull Request Checklist (Author)
Ticket & Documentation
Bugfix-Specific Checks
Testing