Skip to content

Add new property for connection pool size - #564

Merged
sebhofmann merged 2 commits into
2024.06.xfrom
issues/docker-image-connection-pool
Sep 28, 2026
Merged

sebhofmann merged 2 commits into
2024.06.xfrom
issues/docker-image-connection-pool

Conversation

@erodde

@erodde erodde commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

tested locally, property now adjustable

@erodde
erodde requested a review from sebhofmann September 21, 2026 14:04
@sebhofmann

sebhofmann commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

The value should be set unconditionally, with a fallback:

setOrAddProperty "MCR.JPA.Connection.MaximumPoolSize" "${JDBC_CONNECTION_POOL_SIZE:-30}"

:- covers both cases, the variable being unset as well as being set to an empty value. The if block at line 120 can be removed.

@erodde

erodde commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

The value should be set unconditionally, with a fallback:

setOrAddProperty "MCR.JPA.Connection.MaximumPoolSize" "${JDBC_CONNECTION_POOL_SIZE:-30}"

:- covers both cases, the variable being unset as well as being set to an empty value. The if block at line 120 can be removed.

done!

@sebhofmann
sebhofmann merged commit 9ac1f0d into 2024.06.x Sep 28, 2026
2 checks passed
@sebhofmann
sebhofmann deleted the issues/docker-image-connection-pool branch September 28, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants