Repository navigation
test: wait for dev server in Playwright config - #121
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesPlaywright WebServer Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Quick CI note: the |
Description
Adds a Playwright
webServerblock so direct Playwright runs wait for the local dev server before starting tests. The repo currently documents the dev app athttp://localhost:5173, so the config waits on that URL with a 120s timeout.The block is skipped when
PW_RUNTIME_CONFIG.baseUrlis provided, so dashboard/external-target runs keep using their injected target instead of forcing the local dev server.Fixes #60
Type of change
Verification
npm ci --ignore-scriptsnpx prettier --check playwright.config.tsnpx playwright test --list --config=playwright.config.tsnpx tsc --noEmit --pretty falsegit diff --checkI also tried
npx playwright test tests/healing.spec.ts --project=chromium --reporter=list, but local browser execution stopped before tests because the Playwright Chromium binary is not installed in this workspace. I did not runnpx playwright installto avoid the extra browser download.Implemented with Codex assistance; I kept the patch focused and manually reviewed the final diff.
Checklist:
Summary by CodeRabbit