Repository navigation
fix(server): eliminate ~2-min test startup delay on Windows - #122
Conversation
Replace `npx playwright` with a direct `node @playwright/test/cli.js` spawn in both the /api/playwright/run and /api/run-dynamic-test handlers. npx + cmd.exe shell resolution was adding 30–90 s of overhead before any test code ran on Windows. Also fire the Render warmup ping concurrently with Playwright startup (was sequential) and cap its timeout at 30 s (was 55 s), removing a second source of blocking delay. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR optimizes Playwright startup performance by replacing npx-based invocation with direct Node CLI execution and refactoring remote server warmup to run concurrently with test execution instead of blocking it, across both Playwright run and dynamic test endpoints, with updates to CHANGELOG, README, and wiki documentation. ChangesPlaywright Startup Optimization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Description
Replaces
npx playwrightwith a directnode @playwright/test/cli.jsspawn in both/api/playwright/runand/api/run-dynamic-test. On Windows,npx+cmd.exeshell resolution was adding 30–90 s of overhead before any test ran. Also fires the Render warmup ping concurrently with Playwright startup (was sequential, blocking up to 55 s) and caps its timeout at 30 s.Net result: test execution begins in ~1–2 s instead of ~2 minutes.
Type of change
Checklist:
Summary by CodeRabbit
New Features
Performance