Repository navigation
Use correct 'LDNS_STATUS_NULL' rather than 'false' in dnssec.c - #310
Open
liweitianux wants to merge 1 commit into
Open
liweitianux wants to merge 1 commit into
liweitianux wants to merge 1 commit into
Conversation
ldns_nsec_bitmap_set_type() and ldns_nsec_bitmap_clear_type() would return 'false' (i.e., LDNS_STATUS_OK) when the input bitmap is NULL. Following the existing convention, correct it to be LDNS_STATUS_NULL.
Contributor
Author
|
However, I'm not very sure whether this is the correct/expected fix, i.e., return an error instead of OK for a I noticed this code mismatch when I was compiling the code in an environment where the enum { false = 0, true = 1 };As a result, the compiler generated the following warnings: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldns_nsec_bitmap_set_type()andldns_nsec_bitmap_clear_type()would returnfalse(i.e.,LDNS_STATUS_OK) when the inputbitmapisNULL.Following the existing convention, correct it to be
LDNS_STATUS_NULL.