Repository navigation
fix(ovxr): use sRGB swapchains for camera panels - #1564
hougantc-nvda wants to merge 2 commits into
Conversation
OVRTX LdrColor is already sRGB encoded. Declare that encoding on the OpenXR swapchain so the compositor can decode the input before applying the stream transfer function. Signed-off-by: Hougant Chen <hougantc@nvidia.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
The contract test's fake runtime offered only UNORM, which the sRGB swapchain change no longer accepts. Offer UNORM first and SRGB second, and assert that the swapchain is created as SRGB. A runtime that offers only UNORM must fail without creating a swapchain. Signed-off-by: Hougant Chen <hougantc@nvidia.com>
Description
Camera PiP panels appear washed out in CloudXR because the native helper uploads sRGB-encoded OVRTX
LdrColorbytes into a Vulkan UNORM swapchain. The compositor interprets the values as linear, which lifts midtones in the encoded stream.Request
VK_FORMAT_R8G8B8A8_SRGBso the compositor decodes the source correctly. The helper checks OpenXR's advertised formats and uploads the camera bytes directly.Type of change
Testing
SKIP=check-copyright-year pre-commit run --all-filesandclang-format-14 --dry-run --Werroron the changed C++ file.Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCO