[26.04_linux-nvidia-bos] drm/ast: DisplayPort edid supports 256 bytes - #574
Closed
kelsey-steele wants to merge 1 commit into
Closed
Conversation
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits...
Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ bf6a773dee59 │ [SAUCE] drm/ast: displayport edid supports 256 bytes │ N/A │ N/A │ jammy_hu, tzimmerm, kelse │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘
Lint results:
E: bf6a773dee59 ("drm/ast: DisplayPort edid supports 256 bytes"): not SAUCE/UBUNTU/Revert but has no upstream reference trailer (cherry picked from commit ... or backported from ...)
|
Collaborator
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Kernel deb builds — 🟢 2/2 passed
Note Build reports and debs are retained for 10 days after the PR closes. Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
Collaborator
|
@kelsey-steele Is this for an NVbug? If so, which one? |
Collaborator
|
@nvmochs - @nvidia-bfigg asked for this
|
Collaborator
That's fine...I'm asking for tracking purposes. If it needs to be tracked, please add to the SS. |
Collaborator
|
|
Collaborator
Author
|
@nvmochs This is for https://nvbugspro.nvidia.com/bug/6291194 I added it to the PR also |
Collaborator
Author
|
@nvmochs this is for the Galaxy project and doesn't need to be tracked. Thank you for the review! |
nirmoy
added
has_2_acks
and removed
help wanted
Collaborator
|
Deleted the ack after read a comment from PR 573. |
nirmoy
added
help wanted
kelsey-steele
force-pushed
the
kelseys/26.04_linux-nvidia-bos-ast-dp-edid-256
branch
from
September 8, 2026 19:16
90bf097 to
a68dc8c
Compare
kelsey-steele
changed the title
kelsey-steele
force-pushed
the
kelseys/26.04_linux-nvidia-bos-ast-dp-edid-256
branch
from
September 8, 2026 19:35
a68dc8c to
71030df
Compare
DisplayPort supports EDID up to 256 bytes (blocks 0 and 1). Update the block check to allow these two blocks. For any block beyond that (i.e. the monitor's EDID is larger than the 256 bytes ASPEED DP can hold), report it as an all-zero block instead of a read failure. Also remove the manual checksum/extension-count patch of block 0's last four bytes. That code was already dead, so the condition can never be true. Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patch.msgid.link/20260819-upstream_ast_dp_edid-v3-1-15d36c28afe2@aspeedtech.com (cherry picked from commit b35be235d92b2826e1111bff4c85e080ffd8ca28 drm-misc-next) Signed-off-by: Kelsey Steele <kelseys@nvidia.com>
kelsey-steele
force-pushed
the
kelseys/26.04_linux-nvidia-bos-ast-dp-edid-256
branch
from
September 8, 2026 19:38
71030df to
bf6a773
Compare
Collaborator
|
|
Collaborator
|
|
nirmoy
added
has_2_acks
and removed
help wanted
Collaborator
|
Merged, closing PR. |
kelsey-steele
deleted the
kelseys/26.04_linux-nvidia-bos-ast-dp-edid-256
branch
September 8, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from LKML as a sauce patch. This patch is under review for upstream acceptance with a passed review by Thomas Zimmermann (DRM maintainer):
https://lore.kernel.org/all/20260819-upstream_ast_dp_edid-v3-1-15d36c28afe2@aspeedtech.com/
Patch description
DisplayPort supports EDID up to 256 bytes (blocks 0 and 1). Update the
block check to allow these two blocks. For any block beyond that
(i.e. the monitor's EDID is larger than the 256 bytes ASPEED DP can
hold), report it as an all-zero block instead of a read failure.
Also remove the manual checksum/extension-count patch of block 0's
last four bytes. That code was already dead, so the condition can never
be true.
Testing
@ltrager previously helped build a linux-nvidia-7.0.0-1018 kernel with this patch for testing which was passed along for tests with the necessary hardware. SMC reported being happy with the results.
NVBug: https://nvbugspro.nvidia.com/bug/6291194
LP: https://bugs.launchpad.net/bugs/2166545