Repository navigation
docs(nvpair-node-scanner): add normative service specification - #133
Merged
Merged
Conversation
Add services/nvpair-node-scanner/spec.md, derived from the Go source and its tests rather than the README, following the structure of the existing specs: sections 1-15, a 7.0 method and notification table, and a closing section on the process model, CLI, and build wiring. It describes the daemon as it runs today: a one-minute eviction window with per-scan probing from the third miss, inference activity as proof of life, and a grace for scans that lose every node at once; a two-second GPU telemetry loop for the scheduler; multi-address peers published as ips= and dialed in their own order; and evidence-based ranking of this host's own published addresses. It also records that the browser has no goodbye fast path, so a cleanly shut-down node is evicted at the one-minute threshold like any other. Documentation only. No Go file is touched and no version changes. Signed-off-by: Terve <ntervalon@nvidia.com>
Noah-Tervalon-Nvidia
requested review from
kjlubick and
nvrithik
and removed request for
kjlubick
September 29, 2026 15:28
Collaborator
|
Service keys: spec says "exactly eight", |
#148 added ServiceLlamaCPP ("lc") to noderec and to serviceKeyOrder between lm and er, so there are nine canonical service keys, not eight. Add the lc row to the section 7.1 table and name lc wherever the spec listed only ol and lm: the broker's engine registrations in sections 3 and 7.1, the facade subscriptions in 7.7, and the inference ports the liveness probe never dials. Signed-off-by: Terve <ntervalon@nvidia.com>
nvrithik
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
services/nvpair-node-scanner/spec.md, the normative specification for the discovery daemon, derived from the Go source and its tests and following the structure of the existing specs.It describes the daemon as it runs today: a one-minute eviction window with per-scan probing from the third miss, inference activity as proof of life, and a grace for scans that lose every node at once; a two-second GPU telemetry loop for the scheduler; multi-address peers published as
ips=and dialed in their own order; and evidence-based ranking of this host's own published addresses.It also records that the browser has no goodbye fast path, so a cleanly shut-down node is evicted at the one-minute threshold like any other.
Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Documentation only: one new file. No Go, desktop, or version changes. The goodbye behavior is recorded as current, not changed.
Validation
node scripts/spdx-headers.mjspasses.develop, including the shareddiscovery,netpick,noderec,reach, andmdnspackages it depends on.Risk
None at runtime.
spec.mdis normative, so please flag any statement that does not match the code.Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation — do not edit it by hand.