[https://nvbugs/6907190][chore] Unwaive test_llm_update_weights_qwen35_35b_bf16 by hchings · Pull Request #21135 · NVIDIA/TensorRT-LLM

hchings · 2026-10-27T21:47:25Z

The waive was added for an intermittent FlashInfer JIT failure ("flashinferMetaInfo.h not found") on DGX_B200 Ray stages. The failure did not reproduce in 10 consecutive local runs on a 4-GPU GB200 node (main at dfcc6f0, one cold FlashInfer cache then warm), so unwaive the test to validate in CI.

Dev Engineer Review

The change removes the waiver for test_llm_update_weights_qwen35_35b_bf16 from tests/integration/test_lists/waives.txt. The separate waiver for test_llm_partial_update_weights_qwen35_mxfp8 remains. The reported intermittent FlashInfer JIT failure did not reproduce in 10 local runs, but the supplied CI runs failed or were unstable and do not identify the failing tests.

QA Engineer Review

The waiver removal means this test is no longer skipped by that waiver. The supplied CI results do not confirm that the test passed. Coverage verdict: needs follow-up.

Per-File QA Perspective

tests/integration/test_lists/waives.txt: Removes the waiver entry for test_llm_update_weights_qwen35_35b_bf16; the separate MXFP8 waiver remains. No test-code changes were made.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

hchings · 2026-10-27T21:47:53Z

/bot run --disable-fail-fast

coderabbitai · 2026-10-27T21:51:06Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: NVIDIA/TensorRT-LLM
Branch: main
File: .coderabbit.yaml
Commit: b7b797a
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 84e4d4f4-d68d-4555-8cad-dcac73fe7481

Commits

Reviewing files that changed from the base of the PR and between bbf06ab and 079060f.

Files selected for processing: 1

tests/integration/test_lists/waives.txt

Files with no reviewable changes: 1

tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The integration test waiver list no longer skips test_llm_update_weights_qwen35_35b_bf16. Its NVIDIA bug reference was also removed.

Changes

Integration test waiver

Layer / File(s)	Summary
Remove test waiver `tests/integration/test_lists/waives.txt`	The list no longer skips `test_llm_update_weights_qwen35_35b_bf16` or includes its NVIDIA bug reference.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: Minimal · up to 07906

The waiver removal is mergeable after normal checks. The reported runs do not confirm that the test passed in CI.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title names the NVBugs ID, uses the [chore] type, and states the main change: unwaiving test_llm_update_weights_qwen35_35b_bf16. It follows the repository template and matches the single-line remo…
Description check		The description gives the reason for the change: an intermittent FlashInfer JIT failure (flashinferMetaInfo.h not found) on DGX_B200 Ray stages. It states the validation done (10 consecutive local run…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the NVBugs ID, uses the [chore] type, and states the main change: unwaiving test_llm_update_weights_qwen35_35b_bf16. It follows the repository template and matches the single-line removal of the waiver in waives.txt.

Full details: Description check

Explanation

The description gives the reason for the change: an intermittent FlashInfer JIT failure (flashinferMetaInfo.h not found) on DGX_B200 Ray stages. It states the validation done (10 consecutive local runs on a 4-GPU GB200 node at main dfcc6f0) and the purpose (validate the unwaive in CI). The template sections Description, Test Coverage, and PR Checklist are still empty placeholders, and the description does not restate the ticket or type. Test Coverage is the main gap, since the change is a test unwaive and the test itself is the coverage.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-10-27T21:54:04Z

PR_Github #80986 [ run ] triggered by Bot. Commit: 96c5329 Link to invocation

tensorrt-cicd · 2026-10-28T02:20:46Z

PR_Github #80986 [ run ] completed with state FAILURE. Commit: 96c5329
/LLM/main/L0_MergeRequest_PR pipeline #66707 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

hchings · 2026-10-28T03:10:35Z

/bot run

tensorrt-cicd · 2026-10-28T03:17:49Z

PR_Github #81050 [ run ] triggered by Bot. Commit: bcfec4f Link to invocation

tensorrt-cicd · 2026-10-28T08:56:18Z

PR_Github #81050 [ run ] completed with state FAILURE. Commit: bcfec4f
/LLM/main/L0_MergeRequest_PR pipeline #66764 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Either:

Wait for the PR to be fully approved — the label is added automatically once approval is complete. Having unresolved open comments is fine, or
If needed, ask a member of NVIDIA/trt-llm-ci-approvers to add the label manually.
Then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

hchings · 2026-10-28T22:12:27Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-10-28T22:19:48Z

PR_Github #81264 [ run ] triggered by Bot. Commit: bbf06ab Link to invocation

tensorrt-cicd · 2026-10-29T01:25:34Z

PR_Github #81264 [ run ] completed with state FAILURE. Commit: bbf06ab
/LLM/main/L0_MergeRequest_PR pipeline #66953 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Either:

Wait for the PR to be fully approved — the label is added automatically once approval is complete. Having unresolved open comments is fine, or
If needed, ask a member of NVIDIA/trt-llm-ci-approvers to add the label manually.
Then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

github-actions · 2026-10-29T03:19:10Z

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

…_35b_bf16 The waive was added for an intermittent FlashInfer JIT failure ("flashinferMetaInfo.h not found") on DGX_B200 Ray stages. The failure did not reproduce in 10 consecutive local runs on a 4-GPU GB200 node (main at dfcc6f0, one cold FlashInfer cache then warm), so unwaive the test to validate in CI. Signed-off-by: Erin Ho <14718778+hchings@users.noreply.github.com>

hchings · 2026-10-29T03:45:10Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-10-29T03:54:02Z

PR_Github #81326 [ run ] triggered by Bot. Commit: 079060f Link to invocation

tensorrt-cicd · 2026-10-29T07:51:55Z

PR_Github #81326 [ run ] completed with state SUCCESS. Commit: 079060f
/LLM/main/L0_MergeRequest_PR pipeline #67010 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

hchings self-assigned this Oct 27, 2026

hchings enabled auto-merge (squash) October 27, 2026 21:47

hchings force-pushed the user/erinh/nvbug_6907190 branch from 96c5329 to bcfec4f Compare October 28, 2026 03:10

hchings force-pushed the user/erinh/nvbug_6907190 branch from bcfec4f to bbf06ab Compare October 28, 2026 22:12

sharabeshj-nvda approved these changes Oct 29, 2026

View reviewed changes

trtllm-agent added the ci: full pre-merge approved label Oct 29, 2026

hchings force-pushed the user/erinh/nvbug_6907190 branch from bbf06ab to 079060f Compare October 29, 2026 03:45

hchings merged commit 0c15889 into NVIDIA:main Oct 29, 2026
9 of 11 checks passed

Conversation

hchings commented Oct 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dev Engineer Review

QA Engineer Review

Per-File QA Perspective

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

hchings commented Oct 27, 2026

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

tensorrt-cicd commented Oct 27, 2026

Uh oh!

tensorrt-cicd commented Oct 28, 2026

Uh oh!

hchings commented Oct 28, 2026

Uh oh!

tensorrt-cicd commented Oct 28, 2026

Uh oh!

tensorrt-cicd commented Oct 28, 2026

Uh oh!

hchings commented Oct 28, 2026

Uh oh!

tensorrt-cicd commented Oct 28, 2026

Uh oh!

tensorrt-cicd commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

hchings commented Oct 29, 2026

Uh oh!

tensorrt-cicd commented Oct 29, 2026

Uh oh!

tensorrt-cicd commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hchings commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading