Skip to content

[None][infra] restore L40S pre-merge stage 2 - #21241

Merged
hanjingtian merged 1 commit into
NVIDIA:mainfrom
hanjingtian:feature/l40s-stage2-restore-20261029
Oct 29, 2026
Merged

hanjingtian merged 1 commit into
NVIDIA:mainfrom
hanjingtian:feature/l40s-stage2-restore-20261029

Conversation

@hanjingtian

@hanjingtian hanjingtian commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove the temporary L40S stage-2 maintenance pause introduced in #21173 so the affected stages can run again.

  • Remove L40S-PyTorch-2 and L40S-PyTorch-2-cbts from jenkins/config/maintenance_stages.txt.
  • Remove the corresponding maintenance reason and retain the file, license, and format documentation.
  • No changes to stage definitions, routing, tests, or waivers.

Validation

  • The existing maintenance merge script produces an empty effective configuration (reason empty and patterns empty) when applying this PR diff to main.
  • git diff --check: passed.
  • Applicable pre-commit checks and DCO check: passed with Python 3.12.
  • Targeted Jenkins validation of L40S-PyTorch-2 will be triggered on this PR; GPU recovery is not yet verified.

Dev Engineer Review

The change removes the maintenance reason and the L40S-PyTorch-2 and L40S-PyTorch-2-cbts entries from jenkins/config/maintenance_stages.txt. This allows those stages to run instead of being skipped for maintenance. The H100 maintenance entries remain. No stage definitions or routing changes are reported.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • jenkins/config/maintenance_stages.txt: Verify that L40S-PyTorch-2 and L40S-PyTorch-2-cbts are eligible to run after the maintenance entries are removed. GPU recovery and stage execution results are not established by the supplied evidence.

Signed-off-by: hanjingtian <312433810+hanjingtian@users.noreply.github.com>
@hanjingtian

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "L40S-PyTorch-2"

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between b7b797a and 990edde.

Files selected for processing: 1
  • jenkins/config/maintenance_stages.txt
Files with no reviewable changes: 1
  • jenkins/config/maintenance_stages.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The maintenance configuration no longer lists the L40S-PyTorch-2 maintenance reason or its two stage entries. The H100 maintenance entries remain.

Changes

Maintenance stage configuration

Layer / File(s) Summary
Remove L40S-PyTorch-2 entries
jenkins/config/maintenance_stages.txt
The configuration no longer includes the L40S-PyTorch-2 maintenance reason or its two stage entries.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: chzblych

Merge Risk: Minimal · up to 990ed

The maintenance pause is removed for the two L40S stage-2 entries. No actionable merge-blocking issue is identified; targeted Jenkins validation remains to be run.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "[None][infra] restore L40S pre-merge stage 2" follows the repository template (ticket tag, type tag, summary). It states the main change: the L40S stage-2 maintenance pause is removed so th…
Description check Passed The description covers the summary and validation sections. It explains that L40S-PyTorch-2 and L40S-PyTorch-2-cbts are removed from maintenance_stages.txt and that stage definitions, routing, tests, …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "[None][infra] restore L40S pre-merge stage 2" follows the repository template (ticket tag, type tag, summary). It states the main change: the L40S stage-2 maintenance pause is removed so the stages can run again. The raw summary confirms that L40S-PyTorch-2 and its two stage entries were removed from maintenance_stages.txt, which matches the title.

Full details: Description check

Explanation

The description covers the summary and validation sections. It explains that L40S-PyTorch-2 and L40S-PyTorch-2-cbts are removed from maintenance_stages.txt and that stage definitions, routing, tests, and waivers are unchanged. It lists validation steps and notes that GPU recovery is not yet verified. It does not fill in the template's Description, Test Coverage, or PR Checklist sections, and it does not state whether the change adds API changes or has a label. These gaps are non-critical for a config-only change, so the description is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81340 [ run ] triggered by Bot. Commit: 990edde Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81340 [ run ] completed with state SUCCESS. Commit: 990edde
/LLM/main/L0_MergeRequest_PR pipeline #67023 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@hanjingtian

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "restore L40s stage"

@hanjingtian
hanjingtian enabled auto-merge (squash) October 29, 2026 06:16
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81367 [ skip ] triggered by Bot. Commit: 990edde Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81367 [ skip ] completed with state SUCCESS. Commit: 990edde
Skipping testing for commit 990edde

Link to invocation

@hanjingtian
hanjingtian merged commit d9c4f3b into NVIDIA:main Oct 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants