Repository navigation
[None][infra] Waive 1 failed cases for main in pre-merge 67018 - #21252
Conversation
Bug(s): 7011673 Requested by: @HuiGao-NV Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive one case" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add modeling_v2 waiver tests/integration/test_lists/waives.txt |
Adds a skip rule for unittest/_torch/modeling_v2 and excludes unittest/_torch/modeling_v2/comm. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: chienchunhung
Merge Risk: 
Minimal · up to 9c909
-
The waiver change is mergeable with no identified actionable risk.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title follows the required [TICKET][type] Summary pattern. It uses [None][infra] and names the main change, a waiver for one failed case on main in pre-merge 67018. It does not name the specific test path or the NVBug, but it matches the changeset's purpose.
Full details: Description check
-
Explanation
The description does not fully follow the template. It gives a bug link and the waive entry, which covers the key information. It leaves out the template's Description and Test Coverage sections and the PR checklist. It also does not explain why the test fails or why the skip is safe. The waive entry is clear, so the description is mostly complete.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #81381 [ skip ] triggered by Bot. Commit: |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
|
PR_Github #81381 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch:
mainBug(s): 7011673
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
unittest/_torch/modeling_v2, except tests underunittest/_torch/modeling_v2/comm. It tracks NVBUG 7011673.QA Engineer Review
tests/integration/test_lists/waives.txt. Added aSKIPentry forunittest/_torch/modeling_v2withcommexcluded.commtests and three model-specific tests in this directory.needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Verify that the selector skips only the intended tests and preserves thecommexclusion. The change is a waiver-list update; no test code changed.