Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 67018 - #21252

Merged
HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261029-070750
Oct 29, 2026
Merged

HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261029-070750

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch: main
Bug(s): 7011673

Waive entries added

unittest/_torch/modeling_v2 --ignore=unittest/_torch/modeling_v2/comm SKIP (https://nvbugs/7011673)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • The waiver skips tests under unittest/_torch/modeling_v2, except tests under unittest/_torch/modeling_v2/comm. It tracks NVBUG 7011673.
  • This directory-level waiver has broader scope than a single failed test. It can hide unrelated failures in the covered directory until the waiver is removed.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt. Added a SKIP entry for unittest/_torch/modeling_v2 with comm excluded.
  • The list already contains specific waivers for two comm tests and three model-specific tests in this directory.
  • No test execution results are provided. Coverage verdict: needs follow-up.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Verify that the selector skips only the intended tests and preserves the comm exclusion. The change is a waiver-list update; no test code changed.

Bug(s): 7011673
Requested by: @HuiGao-NV

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@HuiGao-NV

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive one case"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 380a490 and 9c909cd.

Files selected for processing: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

Walkthrough

The integration test waiver list adds a skip rule for unittest/_torch/modeling_v2, excluding its comm subdirectory.

Changes

Modeling V2 test waiver

Layer / File(s) Summary
Add modeling_v2 waiver
tests/integration/test_lists/waives.txt
Adds a skip rule for unittest/_torch/modeling_v2 and excludes unittest/_torch/modeling_v2/comm.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: chienchunhung

Merge Risk: Minimal · up to 9c909

The waiver change is mergeable with no identified actionable risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title follows the required [TICKET][type] Summary pattern. It uses [None][infra] and names the main change, a waiver for one failed case on main in pre-merge 67018. It does not name the specific t…
Description check Passed The description does not fully follow the template. It gives a bug link and the waive entry, which covers the key information. It leaves out the template's Description and Test Coverage sections and t…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title follows the required [TICKET][type] Summary pattern. It uses [None][infra] and names the main change, a waiver for one failed case on main in pre-merge 67018. It does not name the specific test path or the NVBug, but it matches the changeset's purpose.

Full details: Description check

Explanation

The description does not fully follow the template. It gives a bug link and the waive entry, which covers the key information. It leaves out the template's Description and Test Coverage sections and the PR checklist. It also does not explain why the test fails or why the skip is safe. The waive entry is clear, so the description is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81381 [ skip ] triggered by Bot. Commit: 9c909cd Link to invocation

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

@HuiGao-NV
HuiGao-NV enabled auto-merge (squash) October 29, 2026 07:24
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #81381 [ skip ] completed with state SUCCESS. Commit: 9c909cd
Skipping testing for commit 9c909cd

Link to invocation

@HuiGao-NV
HuiGao-NV merged commit 29cc04e into NVIDIA:main Oct 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants