Repository navigation
Conversation
…44.0 Reasoner notebook: the Cosmos3-Super-FP8 launch on vllm/vllm-openai:v0.31.0 needs --trust-request-mm-kwargs. Without it every video request, which sends media_io_kwargs (num_frames, fps), is rejected with HTTP 400. Image requests were unaffected. Quantization cookbook: pin nvidia-modelopt[torch]==0.44.0 in the README and the three notebooks instead of installing whatever is latest. Validated the reasoner change by running the notebook against nvidia/Cosmos3-Super-FP8 at TP=4 on 4 B200 GPUs: all cells ran and all video requests returned content. The modelopt pin was not re-run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
| " --tensor-parallel-size 4 \\\n", | ||
| " --mm-encoder-tp-mode data \\\n", | ||
| " --async-scheduling \\\n", | ||
| " --trust-request-mm-kwargs \\\n", |
There was a problem hiding this comment.
Thanks for fixing the video-request compatibility issue. Could we please make the trusted-client requirement explicit next to this flag and bind the local notebook example to 127.0.0.1:8001:8000? vLLM documents this flag as appropriate only for trusted API clients, since per-request media/preprocessing overrides can increase CPU/GPU/memory consumption. The current -p 8001:8000 publishes on all host interfaces, with no API authentication configured in this launch command; if that port is reachable by untrusted clients, they can use those overrides too. The notebook requests already target localhost, so loopback-only publication plus a short trusted-client note would retain the intended fix without widening access by default. Remote serving could remain a separately documented, explicitly access-controlled option. Thank you!
There was a problem hiding this comment.
Following up on the existing inline note: leaving this unmerged while it is Draft and explicitly marked DO NOT MERGE. Please address the trusted-client/local-port boundary above, and clarify which validation results apply to the pinned ModelOpt 0.44.0 environment before lifting the hold; the description currently says the pin was not run and the saved outputs reflect other versions. This is not a claim of a demonstrated 0.44.0 API incompatibility, and no additional test file is being requested. Thank you!
DO NOT MERGE
Summary
--trust-request-mm-kwargsto the Cosmos3-Super-FP8 launch onvllm/vllm-openai:v0.31.0. Video requests sendmedia_io_kwargs(num_frames,fps), and without this flag the server rejects every one with HTTP 400. Image requests were not affected.nvidia-modelopt[torch]==0.44.0in the README and the three notebooks instead of installing whatever is latest.Follow-up to #329.
Why
A run of the Reasoner notebook on the published
nvidia/Cosmos3-Super-FP8withvllm/vllm-openai:v0.31.0at TP=4, launch command as written, passed all image cells but failed all 10 video cells with HTTP 400. The server needs--trust-request-mm-kwargsto accept per-request media kwargs.Validation
nvidia/Cosmos3-Super-FP8at TP=4 on 4 B200 GPUs withvllm/vllm-openai:v0.31.0. All code cells ran without errors, the 12 video requests returned content, and the server log had no 400s.mainis built differently (MOUNTSarray,$FP8_MODEL_DIR) but has identical vLLM arguments, and I applied the same one-line edit. It has not been re-run on the merged notebook.Notes
vllm/vllm-openai:cosmos3image, which I did not test with the flag.