Use enums to validate their own values#2333
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
mdboom
added
the
PR review get-together
rwgk
approved these changes
Jul 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there were a few places in the code base where we were validating enums by checking from a set of values (which were copied from the enum itself) and then raising an exception with the acceptable values (also copied from the enum itself). This is 3 places to keep in sync as the acceptable values change.
This uses a helper function to validate that a str is an acceptable value for an enum and provides a consistent error message.