ci: skip multi-arch manifest publish when push is disabled - #2485
Conversation
|
@fallintoplace can you please check and make sure you have signed your commit |
|
@kvalliyurnatt Let me check real quick. Sorry for that. |
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
ce777d9 to
0fa5039
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe image build workflow now runs the multi-architecture manifest build and push job only when Merge Risk: ⚪ Minimal · up to The workflow will now skip multi-architecture manifest publishing when image pushes are disabled, avoiding an invalid manifest publication attempt in non-push contexts. No actionable merge-blocking risk remains beyond normal checks and review. Comment |
|
/ok to test 0fa5039 |
|
Thank you for you contribution @fallintoplace ! |
Summary
push_on_buildisfalseWhy
The per-arch image builds already honor
push_on_buildthrough the build output settings, but the final manifest job still runs unconditionally.That leaves us with an inconsistent flow in non-push contexts: the workflow can skip pushing the arch images and then still try to create and push a multi-arch manifest that references images that were never published.
This showed up after the CI workflow split introduced
push_on_buildinto the modular workflows, but the manifest job never started consuming that signal.Validation
git diff --checkruby -e 'require "yaml"; YAML.load_file(".github/workflows/image-builds.yaml")'I did not run the workflow end-to-end locally.