Skip to content

ci: skip multi-arch manifest publish when push is disabled - #2485

Merged
tariq1890 merged 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/skip-multiarch-manifest-when-push-disabled
Sep 2, 2026
Merged

ci: skip multi-arch manifest publish when push is disabled#2485
tariq1890 merged 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/skip-multiarch-manifest-when-push-disabled

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • skip the multi-arch manifest job when push_on_build is false

Why

The per-arch image builds already honor push_on_build through the build output settings, but the final manifest job still runs unconditionally.

That leaves us with an inconsistent flow in non-push contexts: the workflow can skip pushing the arch images and then still try to create and push a multi-arch manifest that references images that were never published.

This showed up after the CI workflow split introduced push_on_build into the modular workflows, but the manifest job never started consuming that signal.

Validation

  • git diff --check
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/image-builds.yaml")'

I did not run the workflow end-to-end locally.

@copy-pr-bot

copy-pr-bot Bot commented May 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

kvalliyurnatt
kvalliyurnatt previously approved these changes Aug 31, 2026
@kvalliyurnatt

kvalliyurnatt commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@fallintoplace can you please check and make sure you have signed your commit

@kvalliyurnatt
kvalliyurnatt dismissed their stale review August 31, 2026 20:17

Commit not signed

@fallintoplace

Copy link
Copy Markdown
Contributor Author

@kvalliyurnatt Let me check real quick. Sorry for that.

Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
@fallintoplace
fallintoplace force-pushed the fix/skip-multiarch-manifest-when-push-disabled branch from ce777d9 to 0fa5039 Compare August 31, 2026 20:19
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: ec2b4713-5830-40f4-bb2f-899ece7b48ec

📥 Commits

Reviewing files that changed from the base of the PR and between f12acb8 and 0fa5039.

📒 Files selected for processing (1)
  • .github/workflows/image-builds.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The image build workflow now runs the multi-architecture manifest build and push job only when push_on_build is set to 'true'.

Merge Risk: ⚪ Minimal · up to 0fa50

The workflow will now skip multi-architecture manifest publishing when image pushes are disabled, avoiding an invalid manifest publication attempt in non-push contexts. No actionable merge-blocking risk remains beyond normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@kvalliyurnatt

Copy link
Copy Markdown
Contributor

/ok to test 0fa5039

@tariq1890

Copy link
Copy Markdown
Contributor

Thank you for you contribution @fallintoplace !

@tariq1890
tariq1890 merged commit 8f79887 into NVIDIA:main Sep 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants