Repository navigation
fix: cn keeps text-title and text-body next to a text color - #57
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock tailwind-merge rules read our custom
text-title/text-bodyas text colors, socn("text-body", "text-foreground")returnedtext-foregroundand the size was silently dropped in every component that also sets a text color (button, badge, dialog description…). It went unnoticed because the inherited size is also 16px; it showed in #56, where a 24px label rendered at 16px.registry/winlab/lib/utils.ts(theutilsitem, installed at@/lib/utils) now buildscnwithcreateCnfromcn/config, registeringtitleandbodyas font sizes.cnfrom it and listutilsas a registry dependency.cn("text-body text-title", "text-foreground") === "text-title text-foreground"; smoke checks the installedlib/utils.tsand button import.Verified on sandbox: all checks and build pass;
cn("text-body", "text-muted-foreground")now keeps both,cn("bg-primary", "bg-muted")still merges tobg-muted.🤖 Generated with Claude Code