Repository navigation
feat: file-upload block - #59
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces portal's 8 upload UIs (trip's drop zone, approve's dashed label that promised drag-and-drop it never had, plain
Input type=filein receipts and door sounds…). shadcn has no upload component, so this is our own, built on the newattachment.rounded-surface,p-6) that is also the picker's label (keyboard focus shows on it);pastealso takes files pasted anywhere on the page, as trip does today.attachmentrows (image thumbnails, icons by kind, size) with a remove button.accept/acceptLabel/maxSize: files that do not fit show as error rows with the reason (不支援這種檔案, 超過 10 MB) and stay out ofvalue.namemirrorsvalueinto a named file input, so it posts insideform-dialog.data-dayon calendar day buttons (lint flagged the unusedday).Verified on sandbox with WebKit (dark): picking a PDF, a PNG, a .docx and an 11 MB PDF gave 2 accepted rows (PNG with thumbnail) and 2 error rows with the right reasons; removing one left 1; no console errors.
🤖 Generated with Claude Code