Repository navigation
ci: check shipped utilities and keyframes, install every item in the smoke test - #70
Merged
Merged
Conversation
…smoke test Two checks the zyx registry already runs: - theme:check also fails when an @Utility or @Keyframes that a registry item ships is missing from app/globals.css, so the site cannot render an item differently from a project that installed it - the smoke test adds every ui, component and block item from the built registry after the hand-written assertions; the seven items since #63 (focus, avatar-stack, countdown, expand-row, number-ticker, chart, signature-pad) were never installed in CI README lists those seven items and no longer says a combobox menu is as wide as its trigger (#67). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DNMgVpzJEQhK39qSpfRJvU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports two checks that zyx1121/www.zyx.tw already runs:
theme:checkfails when an@utilityor@keyframesshipped by a registry item is missing fromapp/globals.css.registry:ui/registry:component/registry:blockitem from the built registry and builds. The 7 items added since feat: focus and quiet (focus, avatar-stack, countdown, expand-row, number-ticker, spring motion) #63 were never installed in CI.README lists those 7 items and fixes the combobox and popover rows after #67.
Test plan
theme:checkpasses on main's globals.css@utility w-menufrom globals.css makestheme:checkfail withglobals.css is missing @utility w-menu (from base)🤖 Generated with Claude Code
https://claude.ai/code/session_01DNMgVpzJEQhK39qSpfRJvU