Make the compact deck of cards a deck of cards subtype - #5410
Draft
out-of-phaze wants to merge 1 commit into
Draft
Make the compact deck of cards a deck of cards subtype#5410out-of-phaze wants to merge 1 commit into
out-of-phaze wants to merge 1 commit into
Conversation
out-of-phaze
added
the
work in progress
MistakeNot4892
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Compact decks of cards (the 36-card decks used for, uh, a few games I guess) are now a
/obj/item/deck/cardssubtype. Reduces a little bit of code duplication.Why and what will this PR improve
Not super sure about this one tbh. Removes a tiny bit of code duplication and allows for more card generation customization?
Authorship
Me