Reduce code duplication in sushi attackby - #5412
Open
out-of-phaze wants to merge 2 commits into
Open
Conversation
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
codequality/sushi-dupe
branch
from
August 13, 2026 22:10
8fdd4b4 to
94a9b36
Compare
MistakeNot4892
previously approved these changes
Aug 25, 2026
out-of-phaze
force-pushed
the
codequality/sushi-dupe
branch
from
August 26, 2026 18:56
94a9b36 to
eb49d2c
Compare
out-of-phaze
added
ready for review
out-of-phaze
marked this pull request as ready for review
August 26, 2026 18:56
Member
Author
|
the sushi also copies the offset from the item on the table. layering is a bit odd, not sure how to make it more intuitive, but this is better than it just defaulting to the middle |
MistakeNot4892
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
moves some of the duplicated sushi code into a proc that we reuse, so only one spot actually
news the sushi.Why and what will this PR improve
better code and also leaves a comment to help with anyone else's confusion about raw chicken sushi