Repository navigation
fix(osv): keep fresh reachability verdicts when enabling osv on an existing INFO.md (main) - #13
Merged
Merged
Conversation
…isting INFO.md When osv was enabled on a project that already had a complete INFO.md, the preserve path overwrote the freshly generated analysis with the old threat model plus osvEnrichment.context. Since that context is now a prompt directive (instructions to emit a graded Dependency reachability block), the persisted INFO.md ended up carrying raw grading instructions and the real verdicts the analysis agent just produced were discarded — so matcher generation saw the stale threat model, not the reachability grades. Enabling osv is a deliberate "re-analyze with dependencies in view" action, so keep the fresh analysis (verdicts included) instead of restoring the preserved copy. The non-osv preserve path is unchanged and still keeps curated content. Adds a coordinator test for the osv + preserved-INFO.md path (verified to fail without the fix). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the preserve-path fix to fork main (same as PR vercel-labs#190 branch, commit dfe75b8).
Bug: enabling
--osvon a project that already had a complete INFO.md overwrote the freshly generated analysis withold threat model + osvEnrichment.context. Because that context is now a prompt directive (not a self-contained section), the persisted INFO.md carried raw grading instructions and the real reachability verdicts were discarded — matcher generation saw the stale threat model.Fix: when osv is enabled, keep the fresh analysis (verdicts included) rather than restoring the preserved copy. Non-osv preserve path unchanged. Adds a coordinator test (verified to fail without the fix).
🤖 Generated with Claude Code