Repository navigation
Free workers when their member model host leaves - #427
Open
clocksmith wants to merge 1 commit into
Open
clocksmith wants to merge 1 commit into
clocksmith wants to merge 1 commit into
Conversation
Cancel abandoned shard loads, release worker resources and return survivors to Start. Guard late load continuations and pacing waits so a new model can start without reloading tabs. Add browser regressions for host close, reload and late completion, plus cancellation and creator-recovery unit tests.
|
Someone is attempting to deploy a commit to the nehanth's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354.
Behavior
When a member model host closes or reloads, surviving workers now free their layers and return to Start. Abandoned loads stop, including during pacing waits; late async completion cannot restore stale readiness. Creator recovery and transient link replacement are preserved. No wire-format or kernel changes.
Regression evidence
Compared base
6b4a24fwith this PR's6988cd6using these browser regressions.hostgonehostreloadhostgone-loadingThe three scenarios contain 18 checks. Base fails all six survivor-cleanup assertions; fix passes 18/18. The 18 focused checks are included in the 101-check full suite; repeated environment runs below are the same checks, not additional unique tests.
Hardware and browser coverage
Hardware specs were verified with read-only inventory after the tests; browser versions and WebGPU backends were recorded during the runs.
Physical-room topology: member model host on the Core i3-1115G4 system; creator and worker on the Apple M3 system—three browser contexts across two physical computers, communicating over real WebRTC UDP host-candidate pairs. A physical-room repeat using Apple Metal on the M3 GPU and SwiftShader on the Core i3 system also passed 18/18; SwiftShader independently reproduced the bug on the Apple M3 system. Test-only context-routing and browser launch overrides are excluded from this PR.
Additional test outcomes
hostgone,hostreload, andhostgone-loadingscenarios pass 18/18 on the fix; base fails all six cleanup assertions.Other checks and limitations
fsimport error. Those failure cases reproduce on base; CI pins Deno 2.9.5.action_requiredbefore jobs run, awaiting maintainer action. Vercel also requires deployment authorization.AI-assisted implementation; source and regression results were inspected locally.