Repository navigation
fix: batch catalog scans and defer status aggregates - #178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog scans previously committed every queue operation and computed full inventory aggregates on every service tick. Each bounded scan now commits metadata, text, coverage and queue cursors together, while background ticks use constant-size scan state and minimal scan results. Default public scan responses retain their existing status fields. Directory traversal inspects newly discovered children before continuing enumeration within a batch.
Rollback closes advanced directory iterators so retries resume from committed cursors. No schema, policy, or SQLite durability settings change.
Validation: focused catalog/admin tests passed 21/21; full
npm testpassed 1,207 tests with 9 skips and zero failures (1,216 total). Regressions cover one transaction per batch, cursor/iterator rollback, atomic metadata/FTS/state rollback, SIGKILL during an open transaction, private/no-follow protections, and background ticks without eager aggregates.git diff --checkand Syncwheel validation passed. Independent review reported no findings.Rollout: the administrative service needs the updated source and a restart after merge. This PR does not change running services.