Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joseph · project thread
statuspreviously fetched sources and tags, persisted version indexes and snapshot leases, and could prune existing snapshots or recursively replace an incomplete checkout. It now observes existing local state and caches; only explicit--refreshpermits cache changes.--offlinewins. Missing evidence is reported without repair. Registry/version/member caches share the central observation scope, cache writers refuse in that scope, and Git status disables optional index writes. Unqualified executable adapters/source drivers and direct remote transports refuse before invocation; cached composite reports remain usable.Consumer behavior change: expired member-report and package-version caches no longer refresh automatically during status reads. The default
fleet-diagnosticswrapper is therefore an observation consumer: after TTL expiry it showsSTALEevidence (or a degraded status from stale package metadata) until an explicit refresh succeeds. Repeating the default read does not renew freshness. The operator or caller needing current evidence now owns the refresh: invokeagentwheel statuswith the same workspace/fleet/profile selectors and--refresh, or explicitly request the diagnostics caller's existing--refreshoption. No new background refresher or schedule is installed. The fleet-control consumer follow-up remains Joseph's separate decision; fleet-control is unchanged here.Incomplete-checkout errors now name the exact preserved directory and its cache parent, instruct the operator to move that directory to a new backup location outside the cache without overwriting a backup, confirm the original path is absent, then repeat the same scoped refresh. A fixture exercises that manual move and successful reclone while preserving the sentinel. No automatic repair or deletion is added. Snapshot path derivation is shared by observation and materialization; import ordering and conservative notifier suppression are covered by the review follow-up.
This PR is stacked on PR #201 at
71101a9b4f92ffad1ee817fe50842506dba202e1and reuses its effects harness. PR #201 must merge first. The base remainsmain; until that prerequisite lands, the diff also includes the baseline. I2 is now an ordinary regression test; I5 remains an expected failure and is outside this fix.Test-first evidence on the unchanged main product code reproduced cold/warm status fetches and leases, global pruning after a newer synthetic source commit, and sentinel loss when
.gitwas missing. The same snapshot invariant then passes with the fix. A separately isolated legacy launcher probe recorded one implicit build on status with a dummy builder. The new genericscripts/agentwheel-local.mjssource launcher refuses missing/stale builds and never builds implicitly. It is not installed by this PR; no existing wrapper or runtime launcher is replaced.The synthetic fixture snapshots HOME, workspace, cache, Git metadata and temp, with a child-process/network observer. Only its exact trace file is excluded. Cases cover cold/warm/offline/refused status reads, cached-source usefulness, a synthetic diagnostics protocol consumer, launcher admission, and bounded explicit refresh. Diagnostics is a consumer of
status --json; no private diagnostics source or configuration is copied here. This is an application-boundary trace, not a kernel sandbox. Other read/preview verbs and observer-versus-refresh concurrency remain separate qualification work; seedocs/read-effects.md.Validation is intentionally lean: typecheck, build, and affected test files run sequentially with one worker and a memory gate. The complete reconciled matrix and smoke checks run only in CI. No merge, install, runtime-home changes, repository settings changes, or release are included. Stop here for independent review before subsequent batches.
Qualification on
667d6d23ca50ab3d9b842ff622811603944ad627: local typecheck, build, and the four affected test files passed sequentially with the RAM gate. CI passed: 1,250 registered and executed tests, 1,250 passed, zero failed or skipped; both CLI smoke checks and the catalogue contract passed. No merge is performed.