Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions tools/lib/amf-memory-record.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ function validateConfidence(metadata, errors) {
}
}

function validateClaim(metadata, body, errors) {
function validateClaim(metadata, body, errors, options = {}) {
const claim = metadata.claim;
if (!claim || typeof claim !== "object" || Array.isArray(claim)) {
errors.push("claim must be an object");
Expand All @@ -352,10 +352,15 @@ function validateClaim(metadata, body, errors) {
validateExactObject(claim, "claim", fields, errors);
const subjectRequiresSealing = Array.isArray(metadata.subjects)
&& metadata.subjects.some((subject) => /^(?:person|relationship):/.test(String(subject?.identityId ?? "")));
const mustBeSealed = ["person", "relationship"].includes(metadata.scope?.type)
|| metadata.claimType === "relationship"
|| ["confidential", "restricted"].includes(metadata.visibility)
|| subjectRequiresSealing;
// Single-tenant deployments may opt out of at-rest sealing for
// person-related claims (PAM_ALLOW_PLAIN_SENSITIVE_CLAIMS or per-call option).
const allowPlainSensitiveClaims = options.allowPlainSensitiveClaims
?? String(process.env.PAM_ALLOW_PLAIN_SENSITIVE_CLAIMS || "").trim() === "true";
const mustBeSealed = !allowPlainSensitiveClaims
&& (["person", "relationship"].includes(metadata.scope?.type)
|| metadata.claimType === "relationship"
|| ["confidential", "restricted"].includes(metadata.visibility)
|| subjectRequiresSealing);
if (mustBeSealed && claim.encoding !== "sealed") {
errors.push("person/relationship scope or subject, relationship claimType, and confidential/restricted visibility require a sealed claim");
}
Expand Down Expand Up @@ -512,7 +517,7 @@ function validateMemoryRecord(content, options = {}) {
if (!VISIBILITIES.has(metadata.visibility)) errors.push("visibility is invalid");
validateConfidence(metadata, errors);
validateSubjects(metadata.subjects, errors);
validateClaim(metadata, parsed.body, errors);
validateClaim(metadata, parsed.body, errors, options);
validateLifecycle(metadata, errors);
validateProvenance(metadata, errors);
for (const key of ["createdAt", "updatedAt"]) {
Expand Down
20 changes: 20 additions & 0 deletions tools/test-amf-memory-record.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -710,3 +710,23 @@ test("applied recovery binds and preserves the validation warning summary", () =
assert.match(warningMismatch.error, /validation warnings do not match/);
assert.equal(fs.existsSync(forgedProposalAbsolute), true);
});

test("plain sensitive claims validate only with the explicit opt-out", () => {
const sensitive = [
{ scope: { type: "person", id: IDS.person }, visibility: "private" },
{ scope: { type: "relationship", id: IDS.relationship }, visibility: "restricted" },
{ claimType: "relationship" },
{ subjects: [{ identityId: IDS.person, role: "subject" }], visibility: "private" }
];
for (const overrides of sensitive) {
const strict = validateMemoryRecord(recordContent(baseRecord(overrides)));
assert.equal(strict.ok, false);
const relaxed = validateMemoryRecord(recordContent(baseRecord(overrides)), { allowPlainSensitiveClaims: true });
assert.equal(relaxed.ok, true, relaxed.errors.join("; "));
}
const relaxedEmpty = validateMemoryRecord(
recordContent(baseRecord({ scope: { type: "person", id: IDS.person }, visibility: "private" })).replace(/claim:.*\n/, 'claim: {"encoding":"plain","text":" "}\n'),
{ allowPlainSensitiveClaims: true }
);
assert.equal(relaxedEmpty.ok, false);
});