Repository navigation
fix: validate capture projections before persisting ownership - #178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing a commit could persist ownership and then fail when the complete integration was replayed. Pending control recovery could also create a manifest commit before capture refused.
Capture now proves the proposed stack and complete integration before writing, checks observed refs under Git transaction locks, and rolls back owned ref and metadata writes on handled persistence failures. It refuses pending control recovery with an explicit scoped remedy. Capture updates the selected manifest and ledger without automatically staging or committing control metadata; optional lane cleanup reports separately after a successful capture.
Validation covers conflicting cherry-pick and merge compositions, concurrent ref and lane changes, persistence rollback, the printed recovery command, commit-hook non-invocation, and interrupted Git transaction responses. All 15 capture fixture cases passed; the broader compatibility run passed 34 cases, with its remaining subprocess fixture corrected and verified separately. Three additional legacy capture checks and 12 module/documentation checks passed. Independent review: READY on 7b74ba3. Version 0.47.20.