If we do it: the per-ecoregion roll-up tables in both vignettes label the precipitation trend in the unit it is actually in. If we never do: readers (and the fish_passage report appendices ported from these vignettes) read a percent-of-normal slope as millimetres per year.
Problem
The per-ecoregion roll-up builds its prcp column from res$trn, which data-raw/*_vignette_data.R computes with cd_trend(ano, ...) — a trend of anomalies. prcp's anomaly type is pct_normal, so the slope is % of normal per year, but the column is named `prcp mm/yr` and the caption says "annual precipitation trend (mm per year)":
vignettes/peace-fwcp.Rmd:758 and the caption at :772vignettes/kootenay-lake.Rmd:854 and the caption at :868
Measured from the committed inst/vignette-data/peace_fwcp.rds: the first ecoregion's annual prcp trend from 1951 has slope 0.0521, on anomalies carrying anomaly_type = "pct_normal", unit = "%".
The plan review for #97 reports that the same label was ported into the fish_passage_peace_2025_reporting and fish_passage_skeena_2025_reporting appendices; not verified here.
Proposed Solution
- Rename the column to
`prcp %/yr` (or % normal/yr) and fix both captions; or, where mm/yr is what the prose wants, trend ts (raw values) instead of ano for prcp.
- Check the downstream appendices for the same label.
Found by the plan review for #97.
If we do it: the per-ecoregion roll-up tables in both vignettes label the precipitation trend in the unit it is actually in. If we never do: readers (and the fish_passage report appendices ported from these vignettes) read a percent-of-normal slope as millimetres per year.
Problem
The per-ecoregion roll-up builds its prcp column from
res$trn, whichdata-raw/*_vignette_data.Rcomputes withcd_trend(ano, ...)— a trend of anomalies. prcp's anomaly type ispct_normal, so the slope is % of normal per year, but the column is named`prcp mm/yr`and the caption says "annual precipitation trend (mm per year)":vignettes/peace-fwcp.Rmd:758and the caption at:772vignettes/kootenay-lake.Rmd:854and the caption at:868Measured from the committed
inst/vignette-data/peace_fwcp.rds: the first ecoregion's annual prcp trend from 1951 has slope0.0521, on anomalies carryinganomaly_type = "pct_normal",unit = "%".The plan review for #97 reports that the same label was ported into the
fish_passage_peace_2025_reportingandfish_passage_skeena_2025_reportingappendices; not verified here.Proposed Solution
`prcp %/yr`(or% normal/yr) and fix both captions; or, where mm/yr is what the prose wants, trendts(raw values) instead ofanofor prcp.Found by the plan review for #97.