Settle the lower tail of flying_height per roll from the logbooks (#60) - #73
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
The 1,962 frames #54 left implausible sit on 42 rolls with one round-feet height each, so the tail is 77 roll-heights. Two instruments that read none of the disputed fields settle 22 of them (1,001 frames): adjacent-frame spacing against the ~60% designed overlap, and the province's scanned flight logbooks, transcribed by hand into data-raw/flying_height_logbooks.csv with three control rolls' catalogue values withheld. Ships inst/extdata/flying_height_rolls.csv (10 dropped-digit, 1 two-digit, 11 right-height-wrong-scale) and an excluded list with a reason for each of the other 55. The height shipped is the logbook's, converted, not the catalogue's times the factor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
fly_footprint(dem = ) consults flying_height_rolls.csv before #54's repair, keyed on film_roll, flying_height, focal_length and scale with numbers formatted identically on both sides, and marks those frames height_source "corrected_roll_table". A height slip must still reconcile the frame's own ratio; a wrong-scale row cannot be asked that, but its height must clear the ground. The table reaches frames catalogued below the terrain, which is how two dropped digits arrive. The terrain note gains a fly#60 section and corrects its r ~ 2 claim, which holds for about half that mass (#72). The #54 decimal-point finding is recorded as #71, not changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
R CMD check on all three runners: "::" import not declared from tibble. dplyr is in Imports and re-exports it. Checked locally with tools:::.check_packages_used_in_tests(), which reports tibble with the old line restored and nothing with the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flying_heightis settled per roll. The 1,962 frames FLYING_HEIGHT is 10.764x too large on 1,589 catalogue frames, so fly_footprint(dem =) sized them at 110 km #54 left"implausible"are 42 rolls with one round-feet height each, so 77 roll-heights. Two witnesses independent of the disputed fields settle 22 of them (1,001 frames):bc7280, catalogued at 60 m and flown at 20,000 ft). Eleven have the right height beside a wrongscale, so FLYING_HEIGHT is 10.764x too large on 1,589 catalogue frames, so fly_footprint(dem =) sized them at 110 km #54's fallback to nominal scale was drawing them 2–10× too wide.fly_footprint(dem = )now readsinst/extdata/flying_height_rolls.csv, keyed on roll + height + lens + scale, and marks those framesheight_source = "corrected_roll_table". The height used is the logbook's, converted.flying_height_rolls_excluded.csvwith its reason (55, 961 frames).Related Issues
bc78065: 1,350 ft logged, 13,500 ft catalogued).Test plan
devtools::test(): 2,279 passed, 0 failed.test-fly_footprint_height_rolls.R:r_correctedrecomputed);R CMD build:creating vignettes ... OK; both CSVs ship;data-raw/andplanning/do not./code-check, three rounds, eight findings fixed:Notes
inst/notes/terrain-correction.mdcovers method, controls and bounds. Spacing cannot tell ×10 from ×10.764; the logbook can.data-raw/height_calibrate-lower_tail_rolls.Rreproduces every figure.data-raw/flying_height_logbooks.csvis the hand transcription.dem, a wrong-scale frame is still sized from its scale.🤖 Generated with Claude Code
https://claude.ai/code/session_0115csb82i78r86GWFzwPzis