Settle the r≈2 mass per roll: half is a wrong scale, not a mislabelled lens (#72) - #77
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Transcribe the logbook pages of the 53 rolls beyond the band in the near_upper sample (185 rows, read blind), settle every sampled roll-height with fly#60's witnesses under a new tail, near_upper, and ship 24 roll-heights (120 frames) at factor 1, scale_wrong. The logbook height cannot separate a wrong lens from a wrong scale, so this tail also requires spacing to reject nominal. 21 roll-heights log a 12" lens and stay on nominal. Tests pin the three-tail census and a near_upper frame sized from its height, with the table row removed as the control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115csb82i78r86GWFzwPzis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scalerecorded too small. They now ship inflying_height_rolls.csvat factor 1 (scale_wrong) under a newtail = "near_upper". Their keys reach at most 3,227 catalogue frames. The nominal fallback drew these frames at 1/r of their width (half at r = 2); they are nowcorrected_roll_tableand sized from their height.flying_height_rolls_excluded.csvwith its reason.fly_footprint()needs no logic change: the table lookup already works on both sides of the band. Only comments and roxygen change, along with the note, NEWS and CLAUDE.md.Related Issues
The rule, which is the load-bearing part
The plan review found that the logbook height cannot separate the two defects. A wrong lens and a wrong scale both mean the crew flew the catalogued height, so factor 1 "agrees" on lens rolls too. For this tail the rule therefore also requires spacing to reject nominal scale, not merely fit the reported height. On a lens roll the reported height implies about 0.80 overlap, against a window top of 0.78, so fitting alone would have accepted lens rolls. This was fixed before the run.
A legible logbook scale equal to the catalogue's would veto a row. No sampled page writes a scale, so the veto never fired.
Logbooks
bc80048_4.jpg) returns 404 upstream.note:focal_mmon these pages is filled only where a focal length is written, never inferred from a camera model, because on this set the lens is the question.Review
Test plan
devtools::test(): FAIL 0 | SKIP 0 | PASS 2537near_upperrows only.near_upperrows removed from the table (mocked), the bc5509 frame falls back toimplausibleat nominal width.pkgdown::check_pkgdown()cleanVersion bump and NEWS heading are left for
/gh-pr-merge.🤖 Generated with Claude Code
https://claude.ai/code/session_0115csb82i78r86GWFzwPzis