Skip to content

python314Packages.python-lsp-black - #543713

Merged
SuperSandro2000 merged 3 commits into
NixOS:masterfrom
djacu:fix/python-lsp-black
Jul 23, 2026
Merged

python314Packages.python-lsp-black#543713
SuperSandro2000 merged 3 commits into
NixOS:masterfrom
djacu:fix/python-lsp-black

Conversation

@djacu

@djacu djacu commented Jul 20, 2026

Copy link
Copy Markdown
Member

python-lsp-black fails to build on the default Python 3.14 / setuptools 82 stack for two independent reasons:

  • tests/test_plugin.py imports pkg_resources, which setuptools 81+ no longer ships → add setuptools_80 to nativeCheckInputs (test-only).
  • black 26.5 split SourceASTParseError out of ASTSafetyError; backport the upstream fix (python-lsp-black#65).

This unblocks spyder.

Result of nixpkgs-review wip (x86_64-linux) — 4 built, 0 failed: python313Packages.python-lsp-black, python314Packages.python-lsp-black, python313Packages.spyder, spyder

Things done


Prepared with Claude Code (Claude Opus 4.8): failure diagnosis, patch, and this PR summary.
Reviewed, built, and verified by me before submission.

@nixpkgs-ci
nixpkgs-ci Bot requested a review from cpcloud July 20, 2026 05:55
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. llm-assisted Contributions that include code generation with LLMs 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 20, 2026
@djacu

This comment was marked as outdated.

Comment thread pkgs/development/python-modules/python-lsp-black/default.nix Outdated
@sarcasticadmin

This comment was marked as outdated.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 22, 2026
djacu and others added 3 commits July 23, 2026 14:38
Two independent breakages on the default Python 3.14 / setuptools 82 stack:

- tests/test_plugin.py imports pkg_resources, which setuptools 81+ no longer
  ships; add setuptools_80 to nativeCheckInputs so it is available at test time.
- black 26.5 split SourceASTParseError out of ASTSafetyError, which the plugin
  did not catch; backport the upstream fix (python-lsp-black#65).

Assisted-by: Claude Code (Claude Opus 4.8)
@SuperSandro2000 SuperSandro2000 changed the title python-lsp-black: fix build python314Packages.python-lsp-black Jul 23, 2026
@SuperSandroBot

Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha (71d8654)

Command: nixpkgs-review pr 543713
Commit: cd7de3a50e463917c554b8d86d3619c2ecd9cdc0 (subsequent changes)
Merge: 9403f2c8f3a9953b9e57521fec3d8afaab0769ef

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/30007853216/attempts/1


x86_64-linux

✅ 5 packages built:
  • python313Packages.python-lsp-black
  • python313Packages.spyder
  • python314Packages.python-lsp-black
  • python314Packages.spyder
  • spyder

aarch64-linux

✅ 5 packages built:
  • python313Packages.python-lsp-black
  • python313Packages.spyder
  • python314Packages.python-lsp-black
  • python314Packages.spyder
  • spyder

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python313Packages.python-lsp-black
  • python314Packages.python-lsp-black

@SuperSandro2000
SuperSandro2000 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into NixOS:master with commit cb454e1 Jul 23, 2026
29 of 31 checks passed
@djacu
djacu deleted the fix/python-lsp-black branch July 23, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants