Repository navigation
Conversation
- Call LoadPosition(amount) when readSafe is false and amount fits within the internal buffer - Avoid falling back to byte array allocation when the current buffer has fewer remaining bytes than requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the fast path in
BinaryReadStream.ReadMemoryrequiredamount < InternalStreamRemaining. Whenever a read hit the initial unloaded state, matchedInternalStreamRemaining, or crossed a buffer boundary, it fell back to allocating anew byte[amount]instead of refilling the internal buffer first.Calling
LoadPosition(amount)when!readSafe && amount <= _data.Lengthrefills the buffer on boundary crossings and keepsreadSafe: falsereads on the zero-allocation slice path.