Repository navigation
Conversation
- Pass the readSafe parameter to ReadMemory in both GetMemory overloads - Avoid allocating a new byte array when readSafe is false and sufficient bytes remain in the internal buffer
Author
|
Mutagen-Modding/Mutagen#749 should be merged before or together with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryReadStream.GetMemorywasn't forwardingreadSafetoReadMemory(amount), so it always defaulted toreadSafe: trueand allocated a newbyte[]on every call even when the caller explicitly passedreadSafe: false.While profiling Mutagen, this accounted for nearly all of the ~95 MB allocated during a single-plugin FrameWalk (~110 B per record) and ~200 MB of the 266 MB allocated during load order scanning.