Repository navigation
Fix macOS extraction tests and Android CI setup - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest upstream snapshot run fails in all three macOS jobs because
rejectsReplaceableParentcreates its fixture below macOS's private user temp directory. The extractor correctly accepts that protected path, and cleanup masks the failed assertion withDirectoryNotEmptyException. The Android job separately fails during SDK setup becausesetup-android@v3requests the removedtoolspackage by default./tmp, preserve assertion failures during cleanup, and cover writable directories protected by a private ancestor. Production extraction checks stay unchanged.platform-toolsin snapshot and release workflows.Validation: reproduced the original macOS failure with Microsoft JDK 17 and Gradle 8.14.3; the complete macOS ARM64 suite now passes (11 passed, 1 existing destructive test skipped). Core and macOS ARM64 publications also build locally. Both workflow YAML files parse successfully and
git diff --checkpasses.All 9 cross-platform Actions jobs pass on commit
4f68c5e90b1eb8b7510eac748011271a9ddaa51d: core, Linux x86_64/ARM64, Windows x86_64/ARM64, macOS x86_64/ARM64, Android (all four ABIs), and iOS. This verifies tests and local Maven publication builds; Central upload is skipped on the fork.Successful validation run: https://github.com/toaster0123/saferalloc/actions/runs/37334533969
Original failed run: https://github.com/NostrGameEngine/saferalloc/actions/runs/35918400680