Repository navigation
Recognize the Darwin platform alias as macOS - #4
Merged
riccardobl merged 1 commit intoOct 5, 2026
Merged
riccardobl merged 1 commit into
riccardobl merged 1 commit into
Conversation
riccardobl
marked this pull request as ready for review
October 5, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows check uses
contains("win"), which also matchesdarwin. Both the runtime loader and core Gradle native-project selection therefore take the Windows branch for the Darwin alias, making the subsequent explicit Darwin/macOS branch unreachable.Change
Use
startsWith("win")in both selectors and add a regression covering Linux, Windows 11, Mac OS X, and Darwin. The regression restores all changed system properties.Scope and severity
This is a compatibility-alias correction. The usual
Mac OS Xvalue already worked; this review did not demonstrate a supported macOS JVM reportingDarwin. It should not be described as a general macOS loading failure.Validation
Darwin -> windowsjava.library.pathfallback, and normal-exit extraction cleanup on Linuxgit diff --checkpassedLimits
The Gradle selector was source-reviewed, not executed with Gradle. Full Gradle/CMake and platform CI were not run locally. No macOS or Windows runtime was available; mocked system properties exercise classification only.