Skip to content

[18.0][MIG] mail_composer_cc_bcc_account: Migration to 18.0 - #4

Draft
trisdoan wants to merge 11 commits into
OCA:18.0from
trisdoan:18.0-mig-mail_composer_cc_bcc_account
Draft

[18.0][MIG] mail_composer_cc_bcc_account: Migration to 18.0#4
trisdoan wants to merge 11 commits into
OCA:18.0from
trisdoan:18.0-mig-mail_composer_cc_bcc_account

Conversation

@trisdoan

@trisdoan trisdoan commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Note

Changes in 18.0

  • Print & send was refactored in https://github.com/odoo/odoo/pull/180212
    => So, instead of patching account.move.send, adding cc/bcc support in account.move.send.wizard

@trisdoan trisdoan mentioned this pull request Nov 12, 2024
Open
38 tasks
@trisdoan
trisdoan marked this pull request as draft December 11, 2024 11:21
@trisdoan

trisdoan commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

DRAFT: working on failed tests

@trisdoan
trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch 3 times, most recently from 076cde7 to 3e395d9 Compare December 16, 2024 02:10
@trisdoan
trisdoan marked this pull request as ready for review December 16, 2024 02:13
@AEstLo

AEstLo commented Apr 4, 2025

Copy link
Copy Markdown

@trisdoan I will happily review and test this module once is ready

@matteotognini

matteotognini commented Apr 7, 2025

Copy link
Copy Markdown

Hi @trisdoan, I would like to test this module. Could you please rebase to reload the runboat? Thanks

@trisdoan
trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch from 3e395d9 to 5f7f087 Compare April 9, 2025 09:03
matteotognini
matteotognini approved these changes Apr 9, 2025
View reviewed changes

@matteotognini matteotognini left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

AEstLo
AEstLo approved these changes Apr 9, 2025
View reviewed changes

@AEstLo AEstLo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@matteotognini

matteotognini commented Jun 10, 2025

Copy link
Copy Markdown

Could it be possible to merge this?

@trisdoan

trisdoan commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Hello @pedrobaeza, could you merge this please?

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 11, 2025
@pedrobaeza

pedrobaeza commented Jun 11, 2025

Copy link
Copy Markdown
Member

A review by a PSC is needed.

@github-actions

github-actions Bot commented Oct 12, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Oct 12, 2025
@github-actions github-actions Bot closed this Nov 16, 2025
@jdidderen jdidderen mentioned this pull request Dec 10, 2025
Closed
@glasl

glasl commented Jan 27, 2026

Copy link
Copy Markdown

Can someone comment on the timeline for this module to be reviewed?

@AEstLo

AEstLo commented Jan 27, 2026

Copy link
Copy Markdown

maybe @StefanRijnhart can merge it?

StefanRijnhart
StefanRijnhart reviewed Jan 28, 2026
View reviewed changes

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like adding cc/bcc to sending by batch is left out here (account.move.send.batch.wizard)? If so, please mention in the roadmap.

Comment thread mail_composer_cc_bcc_account/wizards/account_move_send_wizard.py
@StefanRijnhart

StefanRijnhart commented Jan 28, 2026

Copy link
Copy Markdown
Member

/ocabot migration mail_composer_cc_bcc_account

@OCA-git-bot

OCA-git-bot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

@github-actions github-actions Bot removed the stale label Feb 1, 2026
@glasl glasl mentioned this pull request Feb 6, 2026
Open
@ChristophAbenthungCibex

ChristophAbenthungCibex commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

any news?

ChristophAbenthungCibex
ChristophAbenthungCibex approved these changes Apr 16, 2026
View reviewed changes

@ChristophAbenthungCibex ChristophAbenthungCibex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and tested the module and it works well

@flotho

flotho commented May 20, 2026

Copy link
Copy Markdown
Member

Hi @trisdoan , any chance to rebase ?
Regards

@trisdoan
trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch from 5f7f087 to 864ae0e Compare August 14, 2026 03:32
@OCA-git-bot OCA-git-bot added series:18.0 mod:mail_composer_cc_bcc_account Module mail_composer_cc_bcc_account labels Aug 14, 2026
@trisdoan
trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch from 864ae0e to 513c482 Compare August 14, 2026 04:46
@trisdoan
trisdoan marked this pull request as draft August 14, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart left review comments
+3 more reviewers
@AEstLo AEstLo AEstLo approved these changes
@matteotognini matteotognini matteotognini approved these changes
@ChristophAbenthungCibex ChristophAbenthungCibex ChristophAbenthungCibex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:mail_composer_cc_bcc_account Module mail_composer_cc_bcc_account series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.