CDM v5.4 documentation migration to quarto and bugfixes - #800
Open
clairblacketer wants to merge 29 commits into
Open
CDM v5.4 documentation migration to quarto and bugfixes#800clairblacketer wants to merge 29 commits into
clairblacketer wants to merge 29 commits into
Conversation
Rebase the develop branch
Rebasing the develop branch
Rebase develop branch
MaximMoinat
approved these changes
Aug 3, 2026
MaximMoinat
left a comment
MaximMoinat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Minor comment on further cleaning the field level csvs.
| @@ -1,552 +1,552 @@ | |||
| cdmTableName,cdmFieldName,isRequired,cdmDatatype,userGuidance,etlConventions,isPrimaryKey,isForeignKey,fkTableName,fkFieldName,fkDomain,fkClass,unique DQ identifiers | |||
Collaborator
There was a problem hiding this comment.
The unique DQ identifiers column seems redundant as it is populated with NA for all rows. Can we remove this column?
Contributor
Author
There was a problem hiding this comment.
I agree, I will remove
MaximMoinat
reviewed
Aug 3, 2026
Collaborator
There was a problem hiding this comment.
I propose to remove the v6.0 documentation. It should not be used and having it here creates maintenance overhead and might confuse people.
Contributor
Author
There was a problem hiding this comment.
I have kept it because some folks in the community requested it. I did remove links to 6.0 from the website though so the only way to get to it is direct urls. Is that enough do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix release of CDM v5.4 prior to releasing CDM v5.5. It also includes the migration of documentation from rMarkdown to Quarto thanks to @MaximMoinat.