Repository navigation
V3.23.24 branch - #7757
Draft
amontenegro wants to merge 7 commits into
Draft
V3.23.24 branch#7757amontenegro wants to merge 7 commits into
amontenegro wants to merge 7 commits into
Conversation
…ic into NotificationMapperV2 and NotificationMapperV3, aligning with the existing mapper architectural pattern. Consolidated item mappings (Item <-> NotificationItemEntity), external identifier mappings, and JSON additionalInfo conversions into NotificationMapperV2 and NotificationMapperV3. Added @AfterMapping post-processing hooks in NotificationMapperV2 and NotificationMapperV3 to guarantee non-null Items containers and null-safe external identifier instances. Updated JpaJaxbNotificationAdapterImpl (v2 and v3) to delegate item mapping and notification post-processing to NotificationMapperV2 and NotificationMapperV3 via Spring component injection. Added comprehensive unit tests in NotificationMapperV2Test and NotificationMapperV3Test verifying bidirectional item mapping and Items initialization.
…tification items by ignoring id when mapping Item to NotificationItemEntity
…pl.findMVPEnabled() and corrected the client ID column identifier in ClientDetailsDaoImpl.updateNotificationInfo() Updated the JPQL query in ClientDetailsDaoImpl.findMVPEnabled() to reference the entity attribute clientType instead of the database column name client_type so that it complies with Hibernate 6 / Spring 6 query syntax. Corrected the primary key column name in the native SQL query within ClientDetailsDaoImpl.updateNotificationInfo() to client_details_id. Added unit test testFindMVPEnabled() in ClientDetailsDaoTest to verify that findMVPEnabled() successfully retrieves MVP-enabled clients.
Member
Author
|
Just a patch branch, DO NOT MERGE! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.