redact: mask secrets embedded in URL query strings and connection strings - #196
Open
CyberSunil wants to merge 2 commits into
Open
CyberSunil wants to merge 2 commits into
CyberSunil wants to merge 2 commits into
Conversation
advaitpatel
self-requested a review
September 23, 2026 16:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 78.95% 86.06% +7.10%
==========================================
Files 26 53 +27
Lines 4158 8145 +3987
==========================================
+ Hits 3283 7010 +3727
- Misses 875 1135 +260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redact.py masks creds in URL userinfo (postgres://user:pw@host) but the same password leaks as a URL query param or connection-string field:
Both return count 0 on main — password goes to the LLM in clear. Common in JDBC/Spring/.NET.
Fix: one pass masking a secret field's value after a compound delimiter (? & ; , or quote). Key stays visible, top-level assignments not double-counted, interpolations left alone.
2 tests fail on main and pass after; 1 regression guard. Full redact suite 13/13.