feat(header): expand UserMenu trigger to show avatar, name - #5547
mohammedeissa7 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Summary by CodeRabbit
WalkthroughThe authenticated user menu now displays the user's name and handle beside the avatar. A chevron indicates the dropdown state and rotates when the menu opens. ChangesUser menu display
Priority: ⬇️ Low — Defer this narrow UserMenu presentation change because it only improves authenticated profile details and dropdown styling in the navbar. Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The authenticated navbar menu now shows profile details and an open-state chevron. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
2 issues found across 1 file
Confidence score: 4/5
- In
frontend/src/components/UserMenu.tsx, sessions without a public display name orlogincan show an empty name row and misrepresent the email local-part as a GitHub handle; add a neutral identity fallback and render the handle only when available. - The added JSX in
frontend/src/components/UserMenu.tsxis inconsistently indented and will fail the repository formatter check; reformat the wrapper, SVG, and path to match surrounding JSX.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/UserMenu.tsx">
<violation number="1" location="frontend/src/components/UserMenu.tsx:89">
P3: The new JSX is inconsistently indented, which fails the repository's formatter check. Reformat the added wrapper, SVG, and path to match the surrounding JSX indentation.</violation>
<violation number="2" location="frontend/src/components/UserMenu.tsx:94">
P3: When a session has no public display name or `login`, the trigger shows an empty name row and presents the email local-part as a GitHub handle. Fall back the display name to a neutral identity value and render the `@` label only for an actual `session.user.login`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
39858ed to
6317fa3
Compare
|
Contribution validation failed:
|
Signed-off-by: Eissa <smme012345@gmail.com>
6317fa3 to
3e997e1
Compare
|



Proposed change
Resolves #3746
The authenticated user button in the navbar previously rendered only a bare avatar circle, giving no visible identity context. This change expands the UserMenu trigger to display the user's avatar, display name, GitHub handle, and an animated chevron
Changes in UserMenu.tsx:
Checklist