Skip to content

Minor language corrections - #159

Merged
aaronbrethorst merged 1 commit into
OneBusAway:mainfrom
goeuropa:main
Aug 22, 2026
Merged

aaronbrethorst merged 1 commit into
OneBusAway:mainfrom
goeuropa:main

Conversation

@wkulesza

@wkulesza wkulesza commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Edited few language strings - both to make end-users understand the meaning better and also to fit into the screen size.

Summary by CodeRabbit

  • Localization
    • Updated Polish translations for time preference labels, trip-planning actions, and turn-by-turn navigation directions.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated Polish localization wording for time preference labels, trip planner actions, and turn-by-turn directions.

Changes

Polish localization

Layer / File(s) Summary
Localization wording updates
OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings
Revised Polish wording for “leave now” labels, shortened trip planner actions, and changed the turn-direction preposition.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: aaronbrethorst

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Polish localization changes and is concise and clear.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings`:
- Line 127: Update the localized value for trip_planner.find_routes to
explicitly mention the route object, using the concise Polish label “Znajdź
trasę” while leaving the key unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 356d99cd-cc50-41ff-99ba-b336707e065c

📥 Commits

Reviewing files that changed from the base of the PR and between a889065 and e5be6a9.

📒 Files selected for processing (1)
  • OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings

Comment thread OTPKit/Sources/OTPKit/Resources/pl.lproj/Localizable.strings
@aaronbrethorst

Copy link
Copy Markdown
Member

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@aaronbrethorst aaronbrethorst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this — translation corrections from someone who actually speaks the language are worth a lot more than anything I could produce, and "fits on the screen" is a real constraint that's easy to miss when writing the English strings.

I checked the mechanical invariants rather than second-guessing your Polish: the diff is values-only across all 6 changes, key parity with en.lproj still holds at 239 keys, the file still lints as a valid .strings plist, and leg.step_turn keeps %1$@/%2$@/%3$@ in the same positions and types. That last one matters because it's formatted in RelativeDirection.swift as (direction, street, distance), and na reads better than w there — the old version produced the doubled "Skręć w lewo w Pine St."

Approving. Merging once CI has run — this PR is from a fork so its build and lint never got approval to start, and main is separately red on a flaky rental test right now. Neither is anything to do with your change.

@aaronbrethorst
aaronbrethorst merged commit 9278f5e into OneBusAway:main Aug 22, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants