Repository navigation
revert: the logo follows the prototype mark again - #133
Merged
Merged
Conversation
This reverts 3defa09, which moved the logo off the Design Prototype's stepped mark onto a starburst supplied from outside it. The 1:1 rule holds for the identity too. The prototype is the reference for layout, type, colour, and the mark, so a drawing that does not come from the prototype does not displace what it draws. All ten files return to their pre-#130 content, byte for byte. `knowhere-mark.svg` is the stepped mark on its `0 0 37 42` viewBox again, `knowhere-footer-mark.svg` draws the same shape in `#F0F2E6`, `knowhere-back-to-top.svg` keeps its `0 0 132 52` lockup, and the favicon, `favicon.ico`, and `app-icon.png` carry the previous drawings. The mark box in `knowhere-brand.tsx`, the Dashboard's mobile sidebar, and the site footer goes back to 37x42. The mark's aspect returns from 1.071 to 0.881, which is the aspect those boxes were drawn for, so the footer's `37x42` pin and the lockup's mark slot fit the drawing instead of letterboxing a wider one inside it. ADR-0029 is kept with `status: superseded by ADR-0030` rather than deleted, and `docs/adr/0030-the-logo-follows-the-prototype-mark.md` records the reversal. `pnpm type-check` clean, `pnpm lint` 0 errors, `pnpm test` 163 passed, and `pnpm test:1-1-contracts` 10 passed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #130 (
3defa09), which moved the logo off the Design Prototype's stepped mark onto a starburst supplied from outside it.The 1:1 rule holds for the identity too. The prototype is the reference for layout, type, colour, and the mark, so a drawing that does not come from the prototype does not displace what it draws.
What came back
public/images/site-chrome/knowhere-mark.svg0 0 37 42viewBoxpublic/images/site-chrome/knowhere-footer-mark.svg#F0F2E6public/images/site-chrome/knowhere-back-to-top.svg0 0 132 52public/assets/knowhere-favicon.svg0 0 42 42boxpublic/favicon.icopublic/images/knowhere/app-icon.pngcomponents/brand/knowhere-brand.tsx, the Dashboard's mobile sidebar brand, and the site footer return to the 37x42 mark box, andlib/app-icon.test.tsreturns to asserting the prototype mark on landing routes.Verified
git diff --stat 3defa09^ HEAD -- <the ten files>is empty.37x42pin and the lockup's mark slot fit the drawing again instead of letterboxing a wider mark inside it.pnpm type-checkclean,pnpm lint0 errors (38 pre-existing warnings),pnpm test163 passed,pnpm test:1-1-contracts10 passed.ADR
docs/adr/0029-the-logo-is-the-knowhere-mark.mdis kept withstatus: superseded by ADR-0030rather than deleted, so both claims stay readable.docs/adr/0030-the-logo-follows-the-prototype-mark.mdrecords the reversal.