Repository navigation
Staging - #136
Open
suguanYang wants to merge 2 commits into
Open
Staging#136suguanYang wants to merge 2 commits into
suguanYang wants to merge 2 commits into
Conversation
The prompt revealed itself as soon as it hydrated, so it asked for an email while the Hero was still the only thing on screen. It now stays unmounted for `NEWSLETTER_PROMPT_DELAY_MS` (ten seconds) after Landing has painted, and reads the dismissal again when the wait ends so a prompt dismissed in another tab does not appear late on this one. The dismissal, the tokens, and the `aria-live="polite"` announce are unchanged. ADR-0031 records the timing rule and amends ADR-0027; `lib/landing-figma-design.test.ts` pins the delay next to the surface tokens so the prompt cannot return to the first paint.
…rompt-delay fix: make the Landing newsletter prompt wait for the content
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.