Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/agent-harness/answer-context.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ function makeLedger(): EvidenceLedgerSnapshot {
data: Buffer.from(revenuePng).toString("base64"),
},
],
evidenceText: [],
stopReasons: [],
failureReasons: [],
decisionTraces: [],
Expand Down
12 changes: 1 addition & 11 deletions src/agent-harness/ledger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ type MutableLedger = {
chunks: EvidenceChunk[]
assets: EvidenceAsset[]
evidence: EvidencePart[]
evidenceText: string[]
stopReasons: string[]
failureReasons: string[]
decisionTraces: unknown[]
Expand Down Expand Up @@ -57,7 +56,6 @@ export function createEvidenceLedger() {
chunks: [],
assets: [],
evidence: [],
evidenceText: [],
stopReasons: [],
failureReasons: [],
decisionTraces: [],
Expand All @@ -70,9 +68,6 @@ export function createEvidenceLedger() {

ledger.evidence.push(...readQueryEvidence(response))

const evidenceText = response.evidenceText?.trim()
if (evidenceText) ledger.evidenceText.push(evidenceText)

const stopReason = response.stopReason?.trim()
if (stopReason) ledger.stopReasons.push(stopReason)

Expand Down Expand Up @@ -193,11 +188,7 @@ export function createEvidenceLedger() {
},

hasEvidence(): boolean {
return (
ledger.chunks.length > 0 ||
ledger.evidence.length > 0 ||
ledger.evidenceText.length > 0
)
return ledger.chunks.length > 0 || ledger.evidence.length > 0
},

snapshot(): EvidenceLedgerSnapshot {
Expand Down Expand Up @@ -607,7 +598,6 @@ function snapshot(ledger: MutableLedger): EvidenceLedgerSnapshot {
chunks: [...ledger.chunks],
assets: [...ledger.assets],
evidence: [...ledger.evidence],
evidenceText: [...ledger.evidenceText],
stopReasons: [...ledger.stopReasons],
failureReasons: [...ledger.failureReasons],
decisionTraces: [...ledger.decisionTraces],
Expand Down
1 change: 0 additions & 1 deletion src/agent-harness/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ export type EvidenceLedgerSnapshot = {
readonly chunks: readonly EvidenceChunk[]
readonly assets: readonly EvidenceAsset[]
readonly evidence: readonly EvidencePart[]
readonly evidenceText: readonly string[]
readonly stopReasons: readonly string[]
readonly failureReasons: readonly string[]
readonly decisionTraces: readonly unknown[]
Expand Down
17 changes: 17 additions & 0 deletions src/app/api/memory-areas/[areaId]/route.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { NextResponse } from "next/server"

import { notebookRequestContext } from "@/domains/workspace/request-context"
import { getMemoryAreaDocument } from "@/integrations/memento/client"
import { withApiErrorResponse } from "@/lib/api-error-response"

export async function GET(
_request: Request,
context: { params: Promise<{ areaId: string }> },
): Promise<NextResponse> {
return withApiErrorResponse("memory-areas:read", async () => {
const { areaId } = await context.params
const { workspace } = await notebookRequestContext.getAuthenticatedWithClient()
const document = await getMemoryAreaDocument(workspace.id, areaId)
return NextResponse.json(document)
})
}
13 changes: 13 additions & 0 deletions src/app/api/memory-areas/route.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { NextResponse } from "next/server"

import { listMemoryAreas } from "@/integrations/memento/client"
import { withApiErrorResponse } from "@/lib/api-error-response"
import { notebookRequestContext } from "@/domains/workspace/request-context"

export async function GET(): Promise<NextResponse> {
return withApiErrorResponse("memory-areas:list", async () => {
const { workspace } = await notebookRequestContext.getAuthenticatedWithClient()
const areas = await listMemoryAreas(workspace.id)
return NextResponse.json({ areas })
})
}
17 changes: 17 additions & 0 deletions src/app/api/memory-items/[itemId]/route.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { NextResponse } from "next/server"

import { notebookRequestContext } from "@/domains/workspace/request-context"
import { deleteMemoryItem } from "@/integrations/memento/client"
import { withApiErrorResponse } from "@/lib/api-error-response"

export async function DELETE(
_request: Request,
context: { params: Promise<{ itemId: string }> },
): Promise<NextResponse> {
return withApiErrorResponse("memory-items:delete", async () => {
const { itemId } = await context.params
const { workspace } = await notebookRequestContext.getAuthenticatedWithClient()
await deleteMemoryItem(workspace.id, itemId)
return NextResponse.json({ deleted: true })
})
}
2 changes: 1 addition & 1 deletion src/components/chat-composer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe("ChatComposer", () => {

const tooltip = await screen.findByRole("tooltip");
expect(tooltip.textContent).toContain(
"Deep search plans document selection and navigation",
"Deep search turns on agent retrieval",
);
});

Expand Down
4 changes: 2 additions & 2 deletions src/components/chat-composer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ export function ChatComposer({
</label>
</TooltipTrigger>
<TooltipContent className="max-w-64">
Deep search plans document selection and navigation for
more thorough answers. Turn off for faster classic search.
Deep search turns on agent retrieval. Turn it off for
classic search without an agent.
</TooltipContent>
</Tooltip>
</TooltipProvider>
Expand Down
94 changes: 94 additions & 0 deletions src/components/memory-documents.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
"use client"

import { useEffect, useState } from "react"
import type { ReactElement } from "react"

type MemoryArea = {
readonly id: string
readonly title: string
readonly summaryStatus: "current" | "pending"
}

type MemoryMember = {
readonly itemId: string
readonly kind: string
readonly status: string
readonly text: string
}

type MemoryDocument = {
readonly id: string
readonly title: string
readonly summaryStatus: "current" | "pending"
readonly summary: string | null
readonly members: readonly MemoryMember[]
}

export function MemoryDocuments(props: {
readonly onBack: () => void
}): ReactElement {
const [areas, setAreas] = useState<readonly MemoryArea[]>([])
const [document, setDocument] = useState<MemoryDocument | null>(null)

useEffect(() => {
void fetch("/api/memory-areas")
.then((response) => response.json())
.then((body: { areas?: readonly MemoryArea[] }) => {
setAreas(body.areas ?? [])
})
}, [])

async function openArea(areaId: string): Promise<void> {
const response = await fetch(`/api/memory-areas/${areaId}`)
setDocument((await response.json()) as MemoryDocument)
}

async function deleteItem(itemId: string): Promise<void> {
if (!document) return
await fetch(`/api/memory-items/${itemId}`, { method: "DELETE" })
await openArea(document.id)
}

return (
<div className="flex h-full min-h-0 flex-col bg-background">
<div className="flex items-center gap-3 border-b border-border px-4 py-3">
<button type="button" onClick={props.onBack}>
Back
</button>
<h2 className="text-sm font-semibold">
{document?.title ?? "MEMORY.MD"}
</h2>
</div>
{document ? (
<div className="min-h-0 flex-1 overflow-y-auto px-4 py-4">
{document.summaryStatus === "current" && document.summary ? (
<p className="mb-4 text-sm">{document.summary}</p>
) : null}
<ul className="flex flex-col gap-4">
{document.members.map((member) => (
<li key={member.itemId}>
<p className="text-xs text-muted-foreground">
{member.kind} {member.status}
</p>
<p className="text-sm">{member.text}</p>
<button type="button" onClick={() => void deleteItem(member.itemId)}>
Delete
</button>
</li>
))}
</ul>
</div>
) : (
<ul className="min-h-0 flex-1 overflow-y-auto px-4 py-4">
{areas.map((area) => (
<li key={area.id}>
<button type="button" onClick={() => void openArea(area.id)}>
{area.title}
</button>
</li>
))}
</ul>
)}
</div>
)
}
17 changes: 17 additions & 0 deletions src/components/sources-panel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export type SourcesPanelProps = {
readonly isNarrow?: boolean;
readonly addingLibrarySourceIds?: readonly string[];
readonly isLibraryOpen?: boolean;
readonly isMemoryOpen?: boolean;
readonly officialLibrarySources?: readonly OfficialLibrarySourceView[];
sources: SourceView[];
onSourceUploaded?: (source: SourceView) => void;
Expand All @@ -64,6 +65,7 @@ export type SourcesPanelProps = {
onArchiveSource?: (sourceId: string) => void;
onRetrySource?: (sourceId: string) => void;
onLibraryOpen?: () => void;
onMemoryOpen?: () => void;
folders?: readonly FolderView[];
currentFolderId?: string | null;
creatingFolder?: boolean;
Expand Down Expand Up @@ -94,6 +96,7 @@ type SourcePageState = {
export function SourcesPanel({
isNarrow = false,
isLibraryOpen = false,
isMemoryOpen = false,
sources = [],
onSourceUploaded,
selectedSourceId = null,
Expand All @@ -102,6 +105,7 @@ export function SourcesPanel({
onArchiveSource,
onRetrySource,
onLibraryOpen,
onMemoryOpen,
folders = [],
currentFolderId = null,
creatingFolder = false,
Expand Down Expand Up @@ -386,6 +390,19 @@ export function SourcesPanel({
<BookOpen className="size-3.5" />
{isNarrow ? null : "open library"}
</button>
<button
type="button"
onClick={onMemoryOpen}
className={`inline-flex h-8 shrink-0 items-center gap-1.5 rounded-md border border-border/80 bg-background text-[11px] font-semibold text-foreground shadow-xs hover:bg-muted ${
isNarrow ? "w-8 justify-center px-0" : "px-2"
} ${
isMemoryOpen ? "border-primary/40 bg-primary/5 text-primary" : ""
}`}
aria-label="Open memory documents"
title="Open memory documents"
>
{isNarrow ? "M" : "memory"}
</button>
</div>
{onOpenFolder ? (
<FolderBreadcrumb
Expand Down
Loading
Loading