Repository navigation
fix: replace legacy Notebook logos with the current Knowhere mark - #187
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Notebook header and login page still displayed the old violet starburst after the website switched to the stepped Knowhere mark. Both now reuse the website SVG with its original proportions. The header adapts to dark mode, while the fixed light login surface keeps a dark mark.
The HTML icon and ICO fallback also use the current mark, and the existing icon contract is updated for SVG. New asset URLs avoid reusing a cached old logo.
Validation: the full GitHub CI workflow passes (lint, typecheck, tests, production build), CodeQL passes, and the Vercel preview deployment is ready. Local TypeScript, targeted ESLint, and all 26 icon/navigation/workspace tests pass. The rendered login page was visually checked, including its fixed light background.