Skip to content

docs: clarify DeepSeek weekday and holiday peak windows - #332

Closed
Frankie-Xu wants to merge 3 commits into
Ontos-AI:mainfrom
Frankie-Xu:fix/Frankie-Xu/deepseek-peak-window-comment
Closed

Frankie-Xu wants to merge 3 commits into
Ontos-AI:mainfrom
Frankie-Xu:fix/Frankie-Xu/deepseek-peak-window-comment

Conversation

@Frankie-Xu

@Frankie-Xu Frankie-Xu commented Aug 25, 2026 •

Copy link
Copy Markdown

Summary

  • Clarify the comment in packages/shared-python/shared/services/ai/token_costing.py: DeepSeek peak windows (01:00-04:00 and 06:00-10:00 UTC) apply Monday through Friday, excluding Chinese public holidays. Weekends and Chinese public holidays are off-peak all day.
  • Wording checked against the current official DeepSeek pricing footnote, including its holiday exception.
  • Merged current main (f9d61119) normally to preserve existing PR history. The resulting PR changes comments only; no pricing rates, model aliases, APIs, defaults, or runtime behavior are changed.

Closes #316.

Verification

  • Dependency-free comparison confirms the updated Python executable AST is identical to current main.
  • Original weekday correction applies cleanly to current main; the final difference is only the peak-window comment.
  • git diff --check passed.
  • Focused Ruff check on token_costing.py passed.
  • ruff check apps packages passed on the synchronized current-main tree through the shared two-slot validation queue.
  • Independent source/spec review completed before push.
  • Required GitHub Actions results are reported separately; pending fork workflow approval is not a passing CI result.

Deployment Notes

  • No new or changed environment variables.
  • No database migrations, queue changes, storage changes, or release-order requirements.
  • Comment-only change; rollback is reverting this PR's comment commits.

Checklist

  • Tests were added or updated when behavior changed — N/A (comments only; executable AST unchanged)
  • Public docs, examples, or OpenAPI contracts were updated when needed — source comment updated
  • Database migrations are idempotent and safe to deploy — N/A
  • Logs, errors, and validation paths avoid leaking secrets or user data — unchanged
  • The pull request description explains any breaking or user-visible change — none

@Frankie-Xu

Copy link
Copy Markdown
Author

This is a first-time fork PR, so GitHub Actions is sitting at action_required. Local make lint / make typecheck / shared tests passed; happy to rebase if needed once workflows are approved.

@Frankie-Xu
Frankie-Xu force-pushed the fix/Frankie-Xu/deepseek-peak-window-comment branch from 74adf86 to 794d40a Compare September 11, 2026 16:14
@cursor
cursor Bot force-pushed the fix/Frankie-Xu/deepseek-peak-window-comment branch from 794d40a to ccb6aa1 Compare September 14, 2026 18:45
@Frankie-Xu

Copy link
Copy Markdown
Author

Rebased onto current main (9489fa2c, includes #414/#415). Comment-only change is unchanged; still waiting on first-time fork Actions workflow approval.

@Frankie-Xu Frankie-Xu changed the title fix: correct DeepSeek peak-window comment to weekdays only docs: clarify DeepSeek weekday and holiday peak windows Oct 7, 2026
@EricNGOntos

Copy link
Copy Markdown
Contributor

Thanks for catching the wording. We're not taking comment-only docs tweaks right now — we'll fold this into the next pass on the DeepSeek pricing notes if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeepSeek peak-window comment is missing "Monday through Friday" (35 h/week, not 49)

2 participants