Repository navigation
test: lock connected image composition during retrieval assembly - #409
Closed
Frankie-Xu wants to merge 2 commits into
Closed
Frankie-Xu wants to merge 2 commits into
Frankie-Xu wants to merge 2 commits into
Conversation
This was referenced Sep 11, 2026
Frankie-Xu
force-pushed
the
test/Frankie-Xu/assemble-connected-image
branch
from
September 12, 2026 05:38
2762887 to
b7fab9e
Compare
Author
|
Rebased onto current Kept both assemble-level image regressions from this PR:
Resolved the conflict with #410's |
The Ontos-AI#206 silent drop is already fixed on main. Add assemble-level coverage in test_asset_inline.py instead of a parallel test module.
cursor
Bot
force-pushed
the
test/Frankie-Xu/assemble-connected-image
branch
from
September 14, 2026 18:45
b7fab9e to
1de2e7d
Compare
Author
Contributor
|
Thanks. We're not landing test-only locks unless they pin a regression we're actively chasing. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retrieval assembly now keeps raw
contentand returns structured evidence incomposed. Update the connected-image regressions to match current main: an image is inserted at its matching placeholder, while an image without a reachable placeholder is skipped without opening storage.The placeholder regression reads a valid tiny synthetic PNG through a mocked storage boundary and checks the exact image bytes and surrounding text order. This is a test-only change; current main is merged with normal history. Related to #206.
Verification
Validated against main
f9d61119using Python 3.11.15 and locked pytest 9.0.3:python -m pytest -p no:postgresql packages/shared-python/shared/tests/test_asset_inline.py -q— 9 passed.python -m pytest -p no:postgresql packages/shared-python/shared/tests/test_asset_inline.py packages/shared-python/shared/tests/test_evidence_compose.py -q— 20 passed.ruff check --no-cache packages/shared-python/shared/tests/test_asset_inline.pywith Ruff 0.15.11 — passed.git diff --checkagainst current main — passed.Dependencies came from a read-only locked API/shared environment plus isolated locked BeautifulSoup/soupsieve wheels. Tests used synthetic settings and fixtures. Complete API/worker suites and external parsing, model, or storage services were not exercised. GitHub workflow approval remains an external gate; empty check rollups do not establish a CI pass.
Deployment Notes
No production code, environment variables, migrations, queues, storage formats, or deployment changes. The assertions follow current main's existing composition contract.
Checklist