Skip to content

test: lock connected image composition during retrieval assembly - #409

Closed
Frankie-Xu wants to merge 2 commits into
Ontos-AI:mainfrom
Frankie-Xu:test/Frankie-Xu/assemble-connected-image
Closed

Frankie-Xu wants to merge 2 commits into
Ontos-AI:mainfrom
Frankie-Xu:test/Frankie-Xu/assemble-connected-image

Conversation

@Frankie-Xu

@Frankie-Xu Frankie-Xu commented Sep 11, 2026 •

Copy link
Copy Markdown

Summary

Retrieval assembly now keeps raw content and returns structured evidence in composed. Update the connected-image regressions to match current main: an image is inserted at its matching placeholder, while an image without a reachable placeholder is skipped without opening storage.

The placeholder regression reads a valid tiny synthetic PNG through a mocked storage boundary and checks the exact image bytes and surrounding text order. This is a test-only change; current main is merged with normal history. Related to #206.

Verification

Validated against main f9d61119 using Python 3.11.15 and locked pytest 9.0.3:

  • Original PR head: python -m pytest -p no:postgresql packages/shared-python/shared/tests/test_asset_inline.py -q — 9 passed.
  • Original assertions after merging current main — 2 failed, 7 passed; both failures reproduced the obsolete flattened-content expectations.
  • Updated branch: python -m pytest -p no:postgresql packages/shared-python/shared/tests/test_asset_inline.py packages/shared-python/shared/tests/test_evidence_compose.py -q — 20 passed.
  • ruff check --no-cache packages/shared-python/shared/tests/test_asset_inline.py with Ruff 0.15.11 — passed.
  • Pyright 1.1.408 with a temporary basic configuration scoped to this test file and the checkout's shared import path — 0 errors.
  • Independent source review and git diff --check against current main — passed.

Dependencies came from a read-only locked API/shared environment plus isolated locked BeautifulSoup/soupsieve wheels. Tests used synthetic settings and fixtures. Complete API/worker suites and external parsing, model, or storage services were not exercised. GitHub workflow approval remains an external gate; empty check rollups do not establish a CI pass.

Deployment Notes

No production code, environment variables, migrations, queues, storage formats, or deployment changes. The assertions follow current main's existing composition contract.

Checklist

  • Tests were added or updated when behavior changed
  • Public docs, examples, or OpenAPI contracts were updated when needed (not applicable)
  • Database migrations are idempotent and safe to deploy (not applicable)
  • Logs, errors, and validation paths avoid leaking secrets or user data (synthetic fixtures only)
  • The pull request description explains any breaking or user-visible change

@Frankie-Xu

Copy link
Copy Markdown
Author

Rebased onto current main (d6f45c7f, includes #410).

Kept both assemble-level image regressions from this PR:

Resolved the conflict with #410's allowed_chunk_types filter tests. Please approve Actions workflows for this first-time fork PR so CI can run.

The Ontos-AI#206 silent drop is already fixed on main. Add assemble-level coverage in test_asset_inline.py instead of a parallel test module.
@cursor
cursor Bot force-pushed the test/Frankie-Xu/assemble-connected-image branch from b7fab9e to 1de2e7d Compare September 14, 2026 18:45
@Frankie-Xu

Copy link
Copy Markdown
Author

Rebased onto current main (9489fa2c, includes #414/#415). test_asset_inline.py had no further conflicts after #410. Still waiting on first-time fork Actions workflow approval.

@Frankie-Xu Frankie-Xu changed the title test: lock connected image inline in assemble_retrieval_results test: lock connected image composition during retrieval assembly Oct 7, 2026
@EricNGOntos

Copy link
Copy Markdown
Contributor

Thanks. We're not landing test-only locks unless they pin a regression we're actively chasing. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants