Decode End of Object Pool response error bits in the log - #15
Open
Arjan-Woltjer wants to merge 1 commit into
Open
Decode End of Object Pool response error bits in the log#15Arjan-Woltjer wants to merge 1 commit into
Arjan-Woltjer wants to merge 1 commit into
Conversation
The Object Pool Error Codes byte (ISO 11783-6:2004 section C.2.5) was only ever logged as a raw integer, leaving every rejection to be looked up against the standard by hand. Adds per-bit decoding into the existing LOG_ERROR call: bit 0 (method/attribute not supported), bit 1 (unknown object reference), bit 2 (other error). Bit 3 (pool deleted from volatile memory) is suppressed unless it's the only bit set, since the standard states a VT should delete the pool from volatile memory on any error at all -- it rides along with essentially every rejection and isn't itself diagnostic on its own. Logging-only change, no control flow affected. Verified against a real rejection on hardware (a Fendt Universal Terminal reporting bitmask value 9 == bit 0 + bit 3) that previously required a manual trip to the ISO standard text to decode; now reads directly off the log.
Arjan-Woltjer
marked this pull request as ready for review
August 11, 2026 07:41
Arjan-Woltjer
commented
Aug 11, 2026
Arjan-Woltjer
left a comment
Author
There was a problem hiding this comment.
Checked against ISO 11783-6 2004, if later versions of this document are available, it is worth checking if the reserved bits 4-7 now have any meaning (in section C.2.5 of the 2004 document they are listed as reserved and transmitted as 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Object Pool Error Codes byte in the End of Object Pool Response message (ISO 11783-6:2004 section C.2.5) was only ever logged as a raw integer (
Pool error bitmask value N), leaving every rejection to be manually looked up against the standard. This adds per-bit decoding into the existingLOG_ERRORcall:Logging-only change; no control flow affected.
Motivation
Hit this directly on real hardware: a Fendt Universal Terminal rejected an object pool with
Pool error bitmask value 9, which required a manual trip to the ISO 11783-6 standard text to decode as bit 0 + bit 3 ("method/attribute not supported" + boilerplate). The referenceVirtualTerminalServerin this ecosystem also hardcodes this byte to0on send (unimplemented), so there's no other place in the codebase that documents this bit layout today.Test plan
TaskControllerClient::ServerOptions's style) over inline bit literals? Happy to rework if so.