refactor(syntax): move the foundation and syntax packages into internal/syntax - #440
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
6 tasks
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
…al/syntax Moves source, ast (with astcodec), pack, diag, lexer, parser and format from internal/core to internal/syntax and rewrites their imports; the hygiene layer test now names the layer directories. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…tial baseline The self-model's Go package references moved to internal/syntax. Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration
Bot
force-pushed
the
refactor/layer-syntax
branch
from
September 19, 2026 15:30
03ee364 to
e780885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
First step of moving every package under
internal/into layer directories, one directory per pull request, bottom-up. This one moves the foundation and syntax packages intointernal/syntax/:A mechanical relocation:
git mv, import-path rewrite across the root module andtools/, and the path strings that follow (Makefile/CI/scripts,sonar-project.properties,packaging/msys2/PKGBUILD, test path strings, the self-model'sgoPackagereferences, the file citations indocs/project/validation-constraints.md). No identifier renames, no behaviour change.tests/hygiene/layering_test.gonow names layers by directory (syntax,semantic,ir,check,exec,translate,doc,workspace,frontend,tooling); the formerfoundationrow folds intosyntax. Every existing tolerated and removed edge is kept.tests/hygiene/protoconv_test.goaccepts imports from any layer directory belowfrontend.The
examplesdigest indocs/project/pilot-differential-baseline.jsonis re-recorded because the self-model'sgoPackagestrings changed; no other figure in the baseline moved.docs/internals/architecture.mdand the roadmap are updated in a docs pull request once the whole stack has landed.How it was verified
go build ./...,go vet ./...,gofmt -l .(empty),make lint,make docs-check, the full suite withOPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./..., thetools/module (build, vet, test,doc-counts -check),python3 scripts/changelog.py check.go list ./internal/... | wc -land thefunc Testcount are unchanged fromdevelop.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog